[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-tech
Subject:    Diff for re(4) to fix chipset flags
From:       Brad Smith <brad () comstyle ! com>
Date:       2012-04-25 0:05:17
Message-ID: 20120425000516.GA11971 () rox ! home ! comstyle ! com
[Download RAW message or body]

The following diff for re(4) corrects some of the feature flags.

The 8401E/8402/8105E/8105E_SPIN1 chipsets shouldn't have Jumbo
frames support enabled.

The 8168D chipset needs to have the PHY wake PM flag set to ensure
the PHY is woken up upon attachment. From FreeBSD.


Index: re.c
===================================================================
RCS file: /home/cvs/src/sys/dev/ic/re.c,v
retrieving revision 1.137
diff -u -p -r1.137 re.c
--- re.c	8 Apr 2012 08:34:55 -0000	1.137
+++ re.c	12 Apr 2012 06:47:31 -0000
@@ -849,7 +849,8 @@ re_attach(struct rl_softc *sc, const cha
 	case RL_HWREV_8105E_SPIN1:
 		sc->rl_flags |= RL_FLAG_INVMAR | RL_FLAG_PHYWAKE |
 		    RL_FLAG_PHYWAKE_PM | RL_FLAG_PAR | RL_FLAG_DESCV2 |
-		    RL_FLAG_MACSTAT | RL_FLAG_CMDSTOP | RL_FLAG_AUTOPAD;
+		    RL_FLAG_MACSTAT | RL_FLAG_CMDSTOP | RL_FLAG_AUTOPAD |
+		    RL_FLAG_NOJUMBO;
 		break;
 	case RL_HWREV_8168_SPIN1:
 	case RL_HWREV_8168_SPIN2:
@@ -862,7 +863,6 @@ re_attach(struct rl_softc *sc, const cha
 		/* FALLTHROUGH */
 	case RL_HWREV_8168C:
 	case RL_HWREV_8168CP:
-	case RL_HWREV_8168D:
 	case RL_HWREV_8168DP:
 		sc->rl_flags |= RL_FLAG_INVMAR | RL_FLAG_PHYWAKE |
 		    RL_FLAG_PAR | RL_FLAG_DESCV2 | RL_FLAG_MACSTAT |
@@ -879,6 +879,7 @@ re_attach(struct rl_softc *sc, const cha
 		 */
 		sc->rl_flags |= RL_FLAG_NOJUMBO;
 		break;
+	case RL_HWREV_8168D:
 	case RL_HWREV_8168E:
 		sc->rl_flags |= RL_FLAG_INVMAR | RL_FLAG_PHYWAKE |
 		    RL_FLAG_PHYWAKE_PM | RL_FLAG_PAR | RL_FLAG_DESCV2 |

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

[prev in list] [next in list] [prev in thread] [next in thread]