[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-ports
Subject:    Re: [new] editors/helix version 22.08.1
From:       Solène Rapenne <solene () perso ! pw>
Date:       2022-10-31 18:47:31
Message-ID: 20221031194731.5d0fc012 () t470
[Download RAW message or body]

Le Mon, 31 Oct 2022 10:07:04 +0100,
Laurent Cheylus <foxy@free.fr> a écrit :

> Hi,
> 
> this is a port for Helix (text editor) https://helix-editor.com
> 
> Features:
>    - Vim-like modal editing
>    - Multiple selections
>    - Built-in language server support
>    - Smart, incremental syntax highlighting and code editing via 
> tree-sitter
> 
> It's my first port for a Rust tool. Tested on amd64, works fine.
> 
> - Makefile defines MASTER_SITES to download helix-22.08.1-source.tar.xz 
> : full sources (Helix + TreeSitter grammars)
> - Special case with EXTRACT_CASES to decompress sources in WRKDIST
> 
> - Patches (derived from those of the FreeBSD port 
> https://github.com/freebsd/freebsd-ports/tree/main/editors/helix/)
>    * patch-helix-term_build_rs: remove Git hash in internal version
>    * patch-helix-loader_src_lib_rs: define path for data directory 
> (${PREFIX}/share/helix)
>    * patch-helix-loader_src_grammar_rs: disable internal command 'hx 
> --grammar fetch' to fetch TreeSitter grammar with Git
> 
> - Install tutor.txt, themes, queries and grammars (.so files built from 
> TreeSitter sources) in ${PREFIX}/share/helix/runtime
> 
> 
> Port also available on GH openbsd-wip 
> https://github.com/jasperla/openbsd-wip/tree/master/editors/helix
> 
> 
> comments welcome, Laurent

the ports looks in good shape and works fine, including LSP support
which I tested with gopls and clangd.

in pkg/DESCR, delete "written in Rust" because this brings
nothing useful, and wrap the long line

remove "post-modern" in the COMMENT, that's not useful

please add ${WRKSRC}/languages.toml into ${PREFIX}/share/helix,
regenerate PLIST after this. this file is useful to use it as a
reference for local tweaks.

with theses changes, it's ok solene@ for import

[prev in list] [next in list] [prev in thread] [next in thread]