[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-ports
Subject:    Re: [NEW] devel/p5-PGObject
From:       Vadim Zhukov <persgray () gmail ! com>
Date:       2019-12-16 19:10:04
Message-ID: CAMy=nGE4_+r71wyF-v18qP_gOB=02u-ewUck64Cgu12NV3+tEA () mail ! gmail ! com
[Download RAW message or body]

пн, 16 дек. 2019 г. в 21:38, Andrew Hewus Fresh <andrew@afresh1.com>:
>
> On Mon, Dec 16, 2019 at 06:18:41AM +0300, Vadim Zhukov wrote:
> > пн, 16 дек. 2019 г. в 03:52, Andrew Hewus Fresh <andrew@afresh1.com>:
> > >
> > > On Fri, Nov 22, 2019 at 02:43:39PM -0800, cpb_ports wrote:
> > > > On Wed, Nov 20, 2019 at 08:50:29PM -0800, Andrew Hewus Fresh wrote:
> > > > > On Wed, Jan 21, 1970 at 02:29:31PM -0800, Chris Bennett wrote:
> > > > > > This is a new module for LedgerSMB, which is WIP.
> > > > > > Several modules require this as base module.
> > > > > >
> > > > > > Any comments or questions?
> > > > >
> > > > >
> > > > > This could use "MAKE_ENV=TEST_POD=yes RELEASE_TESTING=''"
> > > > > so that tests work the same no matter the environment.
> > > > >
> > > > > Other than that, OK afresh1@ if someone wants to import.
> > > > >
> > > >
> > > > New diff attached
> > > >
> > > > Chris Bennett
> > >
> > > Looking at this again, we can enable the database tests with a few extra
> > > lines in the Makefile.
> > >
> > > MAKE_ENV +=     DB_TESTING=1
> > > MODULES +=      databases/postgresql
> > > TEST_DEPENDS += databases/p5-DBD-Pg
> > >
> > > MODPOSTGRESQL_TEST_CMD = \
> > >         ${LOCALBASE}/bin/psql -d postgres \
> > >             -c 'CREATE ROLE postgres WITH LOGIN CREATEDB'; \
> >
> > Hm-m-m, we probably need to add "-s" to createuser command in
> > postgresql.port.mk?
> >
> >         ${LOCALBASE}/bin/createuser postgres || \
>
> I don't have this line in my postgresql.port.mk, but we could use it
> instead of the `CREATE ROLE` query above.

Argh, I completely forgot that creatuser bits were rotting in my tree
for ages... Since the postgresql.port.mk is used only for tests, I'll
just proceed then.

-- 
  WBR,
  Vadim Zhukov

[prev in list] [next in list] [prev in thread] [next in thread]