[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-bugs
Subject:    system/1206: (no subject)
From:       Anders Thulin <ath () algonet ! se>
Date:       2000-04-23 15:13:51
[Download RAW message or body]


>Number:         1206
>Category:       system
>Synopsis:       semi-buggy(?) environment handling in writefile() in at.c (at(1))
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 23 09:20:01 MDT 2000
>Last-Modified:
>Originator:     Anders Thulin
>Organization:
net
>Release:        2.6
>Environment:

        System      : OpenBSD 2.6
        Architecture: OpenBSD.sparc
        Machine     : sparc
>Description:
        /usr/src/usr.bin/at/at.c, l. 319 tests the variable 'ap' for NULL.
        Yet, in that particular context, it doesn't seem to make sense to
        make such a check -- testing 'eqp', set in the previous line,
	seems to be what's really intended.

>How-To-Repeat:
        not applicable

>Fix:
	Suggested fix:

*** at.c.orig   Tue Sep 15 01:56:16 1998
--- at.c        Sun Apr 23 16:43:27 2000
***************
*** 316,322 ****
                char *eqp;

                eqp = strchr(*atenv, '=');
!               if (ap == NULL)
                        eqp = *atenv;
                else {
                        int i;
--- 317,323 ----
                char *eqp;

                eqp = strchr(*atenv, '=');
!               if (eqp == NULL)
                        eqp = *atenv;
                else {
                        int i;

-- 
Anders Thulin     ath@algonet.se     http://www.algonet.se/~ath

>Audit-Trail:
>Unformatted:

[prev in list] [next in list] [prev in thread] [next in thread]