[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-bugs
Subject:    user/704: sendbug uses 'send-pr', contains unused error code
From:       krw () tcn ! net
Date:       1999-01-24 13:56:46
[Download RAW message or body]


>Number:         704
>Category:       user
>Synopsis:       sendbug uses 'send-pr', contains unused error code
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 24 07:10:02 MST 1999
>Last-Modified:
>Originator:     Kenneth R Westerback
>Organization:
>Release:        2.4-current
>Environment:
	
	System      : OpenBSD 2.4
	Architecture: OpenBSD.i386
	Machine     : i386
>Description:
	The /usr/bin/sendbug script that the logon message exhorts
	us to use refers to 'send-pr' and 'SEND-PR' in a number of 
	places. Since OpenBSD uses the name 'sendbug' instead of
	'send-pr' (though 'sendbug' sounds more ominous to me...)
	should not this text be used?

	I include a simple patch but I don't know if gnats 
	requires some 'send-pr's to work.

	One place where 'send-pr' is used extensively is in an
	error message that would be generated if $SUBMITTER is
	'unknown'. Since $SUBMITTER is set to 'net' at the top
	of the script, perhaps this entire section can just be
	excised. Especially as it refers to 'install-sid', which
	does not appear to exist on my system. It also asks you
	to 'send-pr --request-id', something I suspect would not
	work.
>How-To-Repeat:
	read /usr/bin/sendbug.	
>Fix:
	Apply the following patch to /usr/src/gnu/usr.bin/sendbug/sendbug.sh:

--- sendbug.sh.orig	Sat Jan 23 00:01:55 1999
+++ sendbug.sh	Sun Jan 24 08:23:05 1999
@@ -23,7 +23,7 @@
 #
 #	$OpenBSD: sendbug.sh,v 1.10 1999/01/20 06:47:05 millert Exp $
 
-# The version of this send-pr.
+# The version of this sendbug.
 VERSION=3.97
 
 # The submitter-id for your site.
@@ -254,15 +254,15 @@
 
 if [ "$SUBMITTER" = "unknown" -a -z "$REQUEST_ID" -a -z "$IN_FILE" ]; then
   cat << '__EOF__'
-It seems that send-pr is not installed with your unique submitter-id.
+It seems that sendbug is not installed with your unique submitter-id.
 You need to run
 
           install-sid YOUR-SID
 
-where YOUR-SID is the identification code you received with `send-pr'.
-`send-pr' will automatically insert this value into the template field
-`>Submitter-Id'.  If you've downloaded `send-pr' from the Net, use `net'
-for this value.  If you do not know your id, run `send-pr --request-id' to 
+where YOUR-SID is the identification code you received with `sendbug'.
+`sendbug' will automatically insert this value into the template field
+`>Submitter-Id'.  If you've downloaded `sendbug' from the Net, use `net'
+for this value.  If you do not know your id, run `sendbug --request-id' to 
 get one from your support site.
 __EOF__
   exit 1
@@ -355,12 +355,12 @@
   else
     for file in $TEMP $REF ; do
       cat  > $file << '__EOF__'
-SEND-PR: -*- send-pr -*-
-SEND-PR: Lines starting with `SEND-PR' will be removed automatically, as
-SEND-PR: will all comments (text enclosed in `<' and `>').
-SEND-PR: 
-SEND-PR: Choose from the following categories:
-SEND-PR:
+SENDBUG: -*- sendbug -*-
+SENDBUG: Lines starting with `SENDBUG' will be removed automatically, as
+SENDBUG: will all comments (text enclosed in `<' and `>').
+SENDBUG: 
+SENDBUG: Choose from the following categories:
+SENDBUG:
 __EOF__
 
       # Format the categories so they fit onto lines.
@@ -370,10 +370,10 @@
 	c=`expr 61 / $l`
 	if [ $c -eq 0 ]; then c=1; fi
 	echo "$CATEGORIES" | \
-        awk 'BEGIN {printf "SEND-PR: "; i = 0 }
+        awk 'BEGIN {printf "SENDBUG: "; i = 0 }
           { printf ("%-'$l'.'$l's", $0);
-	    if ((++i % '$c') == 0) { printf "\nSEND-PR: " } }
-            END { printf "\nSEND-PR:\n"; }' >> $file
+	    if ((++i % '$c') == 0) { printf "\nSENDBUG: " } }
+            END { printf "\nSENDBUG:\n"; }' >> $file
 
       cat >> $file << __EOF__
 To: $GNATS_ADDR
@@ -381,7 +381,7 @@
 From: $FROM
 Cc: $CC
 Reply-To: $REPLYTO
-X-send-pr-version: $VERSION
+X-sendbug-version: $VERSION
 
 
 >Submitter-Id:	$SUBMITTER
@@ -421,7 +421,7 @@
   else
     ed -s $TEMP << '__EOF__'
 /^Subject/s/^Subject:.*/Subject: request for a customer id/
-/^>Category/s/^>Category:.*/>Category: send-pr/
+/^>Category/s/^>Category:.*/>Category: sendbug/
 w
 q
 __EOF__
@@ -548,7 +548,7 @@
 #
 # /^>Originator:/s;$ORIGINATOR;;
 sed  -e "
-/^SEND-PR:/d
+/^SENDBUG:/d
 /^>Organization:/,/^>[A-Za-z-]*:/s;$ORGANIZATION_C;;
 /^>Confidential:/s;<.*>;;
 /^>Synopsis:/s;$SYNOPSIS_C;;

>Audit-Trail:
>Unformatted:

[prev in list] [next in list] [prev in thread] [next in thread]