[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openais
Subject:    [Openais] depending on your ip address,
From:       "angus salkeld" <angus.salkeld () alliedtelesis ! co ! nz>
Date:       2008-11-27 17:49:36
Message-ID: 492F94800200007000011F11 () gwia ! alliedtelesyn ! co ! nz
[Download RAW message or body]

Hi

If you ip addresses are larger than 0xffffff then you will never
get sent group leave notifications (we are using 192.168.x.x).

The patch below sorts this out.

Can anyone tell me why api->totem_nodeid_get() returns an int
but everything else is an unsigend int? The following line is
comparing signed & unsigned. (services/cpg.c:~715).

		if (lowest_nodeid == api->totem_nodeid_get()) {


Regards
Angus

diff --git a/services/cpg.c b/services/cpg.c
index 01405e0..fe76392 100644
--- a/services/cpg.c
+++ b/services/cpg.c
@@ -694,7 +694,7 @@ static void cpg_confchg_fn (
        struct memb_ring_id *ring_id)
 {
        int i;
-   uint32_t lowest_nodeid = 0xffffff;
+ uint32_t lowest_nodeid = 0xffffffff;
        struct iovec req_exec_cpg_iovec;

        /* We don't send the library joinlist in here because it can end up
_______________________________________________
Openais mailing list
Openais@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/openais
[prev in list] [next in list] [prev in thread] [next in thread]