[prev in list] [next in list] [prev in thread] [next in thread] 

List:       open1x-xsupplicant
Subject:    Re: [Open1x-xsupplicant] Plugin handler code
From:       Terry Simons <galimore () mac ! com>
Date:       2007-09-28 5:06:22
Message-ID: 452B0D58-C3F0-4DC3-8F85-C72B9C45CACA () mac ! com
[Download RAW message or body]

Hi Renato,

In answer to the specific questions you asked:

The plugin code is brand new... and the files are no longer empty as  
of last night. ;)

There are a lot of compiler warnings on the *NIX platforms that need  
to be cleaned up.  XSupplicant used to be fairly warning-free, but the  
changes in the last year have occurred mostly on the Windows platform,  
and the Visual Studio compiler doesn't complain the same as GCC  
(though the Windows code still has a few things that need to be  
cleaned up as well).

I'm not quite done with the plugin code, but I wanted to at least get  
it committed, so I'm sure there are a few issues. ;)

The merge back to HEAD was so we can start doing new development.  The  
XSUP_1_3_BRANCH is going to slow down, so if you're interested in new  
development or if you want to submit patches they should go against  
HEAD.

The relative path thing is something we've been talking about fixing.   
Our opinion aligns with yours in that we would prefer to #include  
"foo.h" rather than relative paths... so patches for that sort of  
thing are definitely welcome.  We've been meaning to go through and  
clean up the tree.  The merge back to HEAD will help facilitate this.

I do like your idea about making things more generic... I honestly had  
a hard time deciding what to name those files.  Too close to the  
action, I guess. ;)

The cardif directory used to be called "os_specific" or some such.  It  
got moved to "cardif" but that may not have been such a good idea.

Thanks for the patch.  I'm going to hold off committing it for now  
because I'm too tired to think and it appears that your code was  
patched before I submitted my latest changes. ;)  I'll try to look at  
it this weekend at the latest.

Thanks for the suggestions... keep them coming! ;)

- Terry


On Sep 27, 2007, at 7:35 AM, seventh guardian wrote:

> Hello,
>
> There is some plugin code in the main branch that seems to be  
> missing from the
> XSUP_1_3_START_BRANCH. Is this code new or deprecated?
>
> I ask this because there are a some compiler warnings about implicit
> declarations. While I was trying to fix them I realized that there is
> a plugin handler header missing (may not have been created yet). I've
> created this header file and made a patch to correct these warnings,
> but it may be futile work if the code is going away ;)
>
> Anyway, the patch makes use of relative paths in the includes (for
> instance #include "../foo.h" or #include "foo/bar.h"). I'd prefer to
> have the build environment checking for the correct path (that is,
> being able to do #include "foo.h" even when the header is not in the
> same dir), but didn't want to touch the build system right now. Maybe
> this should be done later?
>
> Finally, I believe the platform specific plugin_handler_<platform>.h
> files should be removed in favor of the generic plugin_handler.h
> header. This would hide the platform specific code behind a generic
> interface. Moreover these files are currently empty (at least after
> the patch is applied :) )
>
> PS: the plugin_handler.h file currently belongs to the src/cardif/
> directory. That may not be the right directory, so please feel free to
> change it to a more suitable location.
>
> Cheers,
>  Renato Caldas
> < 
> plugin_handler 
> .patch 
> > 
> < 
> plugin_handler 
> .h 
> > 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/_______________________________________________
> Open1x-xsupplicant mailing list
> Open1x-xsupplicant@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open1x-xsupplicant


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Open1x-xsupplicant mailing list
Open1x-xsupplicant@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open1x-xsupplicant
[prev in list] [next in list] [prev in thread] [next in thread]