[prev in list] [next in list] [prev in thread] [next in thread] 

List:       olpc-linux-mm-cc
Subject:    [linux-mm-cc] [UTIL PATCH] add new proc entry to fix algorithm
From:       m-ikeda () ds ! jp ! nec ! com (IKEDA Munehiro)
Date:       2007-05-09 11:57:47
Message-ID: 4641B73B.60800 () ds ! jp ! nec ! com
[Download RAW message or body]

Nitin Gupta wrote:
> Hi,
> 
> Changes look good. Trivial comments below.
> 
> 
>>+               .data           = &ccache_fixed_algo,
> 
> 
> s/ccache_fixed_algo/ccache_selected_algo - looks clearer.

I agree.


>>+int sysctl_cc_algorithm(ctl_table *table, int write,
>>+       struct file *file, void __user *buffer, size_t *length, loff_t *ppos)
>>+{
>>+       return proc_dointvec_minmax(table, write, file, buffer, length, ppos);
>>+}
>>+
> 
> 
> It will be good to show available compression algos (idx-name pair)
> when this proc entry is read.

OK. I'll do it and post later.

Thank you for good sugestions.


Best regards,
IKEDA, Munehiro


[prev in list] [next in list] [prev in thread] [next in thread]