[prev in list] [next in list] [prev in thread] [next in thread]
List: ocfs2-devel
Subject: Re: [Ocfs2-devel] [PATCH 05/15] Add xattr header in ocfs2.v2
From: Joel Becker <Joel.Becker () oracle ! com>
Date: 2008-07-19 0:44:37
Message-ID: 20080719004437.GE659 () ca-server1 ! us ! oracle ! com
[Download RAW message or body]
On Fri, Jun 27, 2008 at 03:01:10PM +0800, Tao Ma wrote:
> Modification from V1 to V2:
> Add EA disk layout to ocfs2_fs.h.
<snip>
> +struct ocfs2_xattr_block {
> +/*00*/ __u8 xb_signature[8];
> + __le16 xb_suballoc_slot;
> + __le16 xb_suballoc_bit;
> + __le32 xb_fs_generation;
> +/*10*/ __le32 xb_csum;
> + __le16 xb_flags;
> + __le16 xb_reserved0;
> + __le64 xb_blkno;
> +/*20*/ __le64 xb_reserved1[2];
> +/*30*/ union {
> + struct ocfs2_xattr_header xb_header;
> + struct ocfs2_xattr_tree_root xb_root;
> + } xb_attrs;
> +};
Hey Tao,
Can you grow xb_csum to a __le64? The actual struct
ocfs2_block_check takes 64bits, so I want to reserve it up front. Maybe
shift xb_blkno above it, then xb_csum, then the flags and resererveds?
Joel
--
"Not being known doesn't stop the truth from being true."
- Richard Bach
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic