[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ocfs2-devel
Subject:    Re: [Ocfs2-devel] [PATCH] ocfs2: Fix writeout
From:       Sunil Mushran <Sunil.Mushran () oracle ! com>
Date:       2008-02-29 20:17:35
Message-ID: 47C8685F.100 () oracle ! com
[Download RAW message or body]

Mark Fasheh wrote:
> Commit f1f540688eae66c274ff1c1133b5d9c687b28f58 "optimized"
> ocfs2_data_convert_worker() to "only do work for regular files".
> Unfortunately, I left out a '!', which casued it to *skip* regular files.
> This was hidden from testing until recently because the default data
> journaling mode (data=ordered) doesn't exercise this code.
>
> Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
>   

Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>

> ---
>  fs/ocfs2/dlmglue.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index 351130c..f4b3dab 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -3042,7 +3042,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
>         	inode = ocfs2_lock_res_inode(lockres);
>  	mapping = inode->i_mapping;
>  
> -	if (S_ISREG(inode->i_mode))
> +	if (!S_ISREG(inode->i_mode))
>  		goto out;
>  
>  	/*
>   


_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
[prev in list] [next in list] [prev in thread] [next in thread]