[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ocfs2-devel
Subject:    Re: [Ocfs2-devel] [PATCH 04/18] ocfs2_dlm: Add missing
From:       Joel Becker <Joel.Becker () oracle ! com>
Date:       2008-02-28 22:40:52
Message-ID: 20080228224052.GG23975 () mail ! oracle ! com
[Download RAW message or body]

On Mon, Feb 25, 2008 at 12:20:48PM -0800, Sunil Mushran wrote:
> The inline comments explain the missing puts in the lockres
> migration paths.

	The comments are readable in a patch email, but not in a 'git
log'.  Can you expound on the problem in the patch header too, please?

> @@ -1919,6 +1946,8 @@ void dlm_move_lockres_to_recovery_list(struct dlm_ctxt *dlm,
>  		     "Recovering res %s:%.*s, is already on recovery list!\n",
>  		     dlm->name, res->lockname.len, res->lockname.name);
>  		list_del_init(&res->recovering);
> +		/* Duh... */
> +		dlm_lockres_put(res);

	Why is this "Duh..."?  People looking later won't have the
benefit of your memory :-)

Joel

-- 

"Practice random acts of kindness and senseless acts of beauty."

 Oh, and don't forget where your towel is.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
[prev in list] [next in list] [prev in thread] [next in thread]