[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nutch-developers
Subject:    Re: [Nutch-dev] svn commit: r416346 [1/3] - in
From:       "=?ISO-8859-1?Q?J=E9r=F4me_Charron?=" <jerome.charron () gmail ! com>
Date:       2006-06-22 20:58:11
Message-ID: c822c4ce0606221358q7e4fa14ha98bf79b53e10cf1 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> I don't think guards should be added everywhere.

That's right Doug.
It was a rude first pass on logging.
The next pass (finest) will be done with NUTCH-310.


> Rather, guards should only be added
> in performance critical code, and then only for "Debug"-level output.
> "Info" and "Warn" levels are normally enabled, and developers should
> thus not log messages at these levels so frequently that performance
> will be compromised.

Yes, but that's actually not the case in Nutch : The major part of logging
statements are using Info level.


>   And not all "Debug"-level log statements need
> guards, only those that are in inner loops, where the construction of
> the log message may significantly affect performance.

I plan to review all the logging statements while working on NUTCH-310,
and I will then follow your directions.

Thanks

Jérôme

-- 
http://motrech.free.fr/
http://www.frutch.org/


Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Nutch-developers mailing list
Nutch-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nutch-developers


[prev in list] [next in list] [prev in thread] [next in thread]