[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ntp-bugs
Subject:    [ntp:bugs] [Bug 887] Error in include/ntp_types.h - patch included
From:       Harlan Stenn via the NTP Bugzilla <bugzilla () ntp ! org>
Date:       2007-08-19 8:45:01
Message-ID: 20070819084501.D368639935 () mail2 ! ntp ! org
[Download RAW message or body]

http://bugs.ntp.org/887


stenn@ntp.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.6


----------------------------------------------------------------------------
Additional Comments From stenn@ntp.org (Harlan Stenn)
Submitted on 2007-08-19 08:45

paapaa125,

Please check ntp-dev and mark this bug as VERIFIED or REOPENED, as appropriate.

Thanks for your patch - I just reordered the #else and #endif lines for that
block.  Now that we require an ANSI C compiler we could use #elsif, but I'll
save that for another day.

#include "Bletch: ..." is an idiom I have used for years.  In my experience
it works better than '#error ...', as the former has always produced both a
useful error message and a "stop" while the latter sometimes produces no
obvious error message and sometimes does not stop.

As far as comment #2 goes, I *believe* that the network packet structures
use intX (or similarly constant sizes).  And I'm not presently aware of any
problems on 64-bit machines.

Anybody disagree?

Thanks for finding this bug and providing a patch!

H

-- 
Harlan Stenn <stenn@ntp.org>



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
bugs mailing list
bugs@lists.ntp.org
https://lists.ntp.org/mailman/listinfo/bugs
[prev in list] [next in list] [prev in thread] [next in thread]