[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nsis-commits
Subject:    [NSIS-commits] SF.net SVN: nsis:[7077] NSIS/trunk/Source
From:       anders_k--- via NSIS-commits <nsis-commits () lists ! sourceforge ! net>
Date:       2019-02-02 20:25:09
Message-ID: 1549139110.153925.30958 () sfp-scm-7 ! v30 ! lw ! sourceforge ! com
[Download RAW message or body]

Revision: 7077
          http://sourceforge.net/p/nsis/code/7077
Author:   anders_k
Date:     2019-02-02 20:25:07 +0000 (Sat, 02 Feb 2019)
Log Message:
-----------
Print "ANSI targets are deprecated" warning if Unicode/Target attributes are never \
used.

Modified Paths:
--------------
    NSIS/trunk/Source/build.cpp
    NSIS/trunk/Source/build.h

Modified: NSIS/trunk/Source/build.cpp
===================================================================
--- NSIS/trunk/Source/build.cpp	2019-01-29 23:15:37 UTC (rev 7076)
+++ NSIS/trunk/Source/build.cpp	2019-02-02 20:25:07 UTC (rev 7077)
@@ -416,6 +416,7 @@
 
   tstring uninst = stubs_dir + PLATFORM_PATH_SEPARATOR_STR + _T("uninst");
   uninstaller_icon = load_icon_file(uninst.c_str());
+  changed_target = false;
 }
 
 
@@ -2568,6 +2569,8 @@
   RET_UNLESS_OK( check_write_output_errors() );
 
   has_called_write_output=true;
+  if (!changed_target && !build_unicode)
+    warning(DW_GENERIC_DEPRECATED, _T("ANSI targets are deprecated"));
 
 #ifdef NSIS_CONFIG_PLUGIN_SUPPORT
   RET_UNLESS_OK( add_plugins_dir_initializer() );
@@ -3898,6 +3901,7 @@
 #ifdef NSIS_CONFIG_PLUGIN_SUPPORT
   if (PS_OK == ec) ec = initialize_default_plugins(true);
 #endif
+  changed_target = true;
   return ec;
 }
 

Modified: NSIS/trunk/Source/build.h
===================================================================
--- NSIS/trunk/Source/build.h	2019-01-29 23:15:37 UTC (rev 7076)
+++ NSIS/trunk/Source/build.h	2019-02-02 20:25:07 UTC (rev 7077)
@@ -108,6 +108,7 @@
   DW_ATTRIBUTE_OVERLONGSTRING = 7060,
   DW_PARSE_BADNUMBER = 7070,
   DW_PARSE_LNK_HK = 7075,
+  DW_GENERIC_DEPRECATED = 7998,
   DW_PARSE_REGPATHPREFIX = 7999,
   DW_INSTFILESPAGE_NOT_USED = 8000, // reserved ..8019
   DW_COMP_FINAL = 8020, // reserved ..8059
@@ -441,6 +442,7 @@
     void print_warnings();
     void warninghelper(DIAGCODE dc, bool fl, const TCHAR *fmt, va_list args);
     DiagState diagstate;
+    bool changed_target;
 
     /** Are we defining an uninstall version of the code?
      * @param un Use like a boolean to define whether in uninstall mode.

This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.



_______________________________________________
NSIS-commits mailing list
NSIS-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nsis-commits


[prev in list] [next in list] [prev in thread] [next in thread]