[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nsis-bugs
Subject:    [NSIS-Bugs] [ nsis-Feature Requests-1787648 ] value of
From:       "SourceForge.net" <noreply () sourceforge ! net>
Date:       2010-06-16 16:03:04
Message-ID: E1OOv4y-0004Hn-Km () sfs-web-1 ! v29 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Feature Requests item #1787648, was opened at 2007-09-04 14:27
Message generated for change (Comment added) made by wizou
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373088&aid=1787648&group_id=22049

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Scripting
Group: 2.0 Series
> Status: Closed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
> Assigned to: Wizou (wizou)
Summary: value of ${__SECTION__} in hidden section

Initial Comment:
In a hidden section but having a name with a '-' prefix, macro __SECTION__ is defined \
but empty

Could you change this so it contains the name of the section, without any prefixes ? \
(as the documentation asserts)

Section "-Test"
!ifdef __SECTION__
!error "Defined: ${__SECTION__}"
!endif
EndSection

Currently it displays
Defined:

My request is to make it display
Defined: Test


----------------------------------------------------------------------

> Comment By: Wizou (wizou)
Date: 2010-06-16 18:03

Message:
Completed: At revision: 6107  

Note: For now, the name is still not stored in the installer. Most of what
MSG suggest is done using the section_index (which is available even for
hidden section), not the name of the section

----------------------------------------------------------------------

Comment By: Wizou (wizou)
Date: 2010-06-16 18:03

Message:
Done in latest CVS version, thanks.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-07-26 13:19

Message:
Logged In: NO 

I would like to place this problem in a slightly broader context:
Currently NSIS does not store the name of a hidden section. This is
illogical (or at least counterintuitive) for the following reasons:
- If you support the use of a - in a section name to hide that section,
you must also support that section name itself. Otherwise, you should only
support hiding by using "" (empty) section names.
- The documentation states: "If section_name is empty, omitted, or begins
with a -, then it is a hidden section". It does not state that if a name
begins with a -, it will be omitted.
- The compiler accepts section names starting with dashes, without giving
a warning that the name will be ignored.

The solution is simple enough: Make NSIS store section names even for
hidden sections. This brings some other advantages as well:
- One might want to unhide a section at some point, or maybe
enable/disable the section while it remains hidden. This would become a lot
easier if one could refer to it with a name.
- LogicLib isn't always able to report the location of a script error. It
would report something like "Error: could not resolve label
"_LogicLib_Label_63" in unnamed install section (0)". Since the
documentation never states that hidden sections are nameless, the user will
be confused: He doesn't know he has any nameless sections. More generally,
finding the error will be easier if the compiler would return the name of
the section instead of the number. Because as far as the programmer is
concerned, the sections do have names.


Forum username: MSG
IRC nick: Message

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373088&aid=1787648&group_id=22049

------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
NSIS-Bugs mailing list
NSIS-Bugs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nsis-bugs


[prev in list] [next in list] [prev in thread] [next in thread]