[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nsis-bugs
Subject:    [NSIS-Bugs] [ nsis-Bugs-2533395 ] Unify uninstaller defines
From:       "SourceForge.net" <noreply () sourceforge ! net>
Date:       2009-01-25 10:44:32
Message-ID: E1LR2Tg-0005Te-Dc () g45xhf1 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Bugs item #2533395, was opened at 2009-01-24 17:55
Message generated for change (Comment added) made by eagle3386
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=2533395&group_id=22049

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Modern UI
Group: 2.0 Series
> Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Martin Baranski (eagle3386)
Assigned to: Joost Verburg (joostverburg)
Summary: Unify uninstaller defines

Initial Comment:
Hey guys,

defining custom texts for the uninstaller is _really_ a bit complicated and not \
logical when compared to MUI's "typical way", i.e.

# Installer
!define MUI_FINISHPAGE_TITLE "${PRODUCT_PUBLISHER} ${PRODUCT_NAME} ${PRODUCT_VERSION} \
                installed!"
!define MUI_FINISHPAGE_TITLE_3LINES
!define MUI_FINISHPAGE_TEXT "Thank you."
!define MUI_FINISHPAGE_TEXT_LARGE
!define MUI_FINISHPAGE_RUN ""
!define MUI_FINISHPAGE_RUN_FUNCTION "myRunFunction"
!define MUI_FINISHPAGE_RUN_TEXT "Launc MyApp"
!define MUI_FINISHPAGE_SHOWREADME "${PRODUCT_WEB_SITE}"
!define MUI_FINISHPAGE_SHOWREADME_TEXT "Open website"
!define MUI_FINISHPAGE_NOAUTOCLOSE
!define MUI_FINISHPAGE_NOREBOOTSUPPORT
!insertmacro MUI_PAGE_FINISH

So, the uninstaller-part should look like this:
# Uninstaller
!define MUI_UNFINISHPAGE_TITLE "${PRODUCT_PUBLISHER} ${PRODUCT_NAME} \
                ${PRODUCT_VERSION} removed!"
!define MUI_UNFINISHPAGE_TITLE_3LINES
!define MUI_UNFINISHPAGE_TEXT "Thank you."
!define MUI_UNFINISHPAGE_TEXT_LARGE
!define MUI_UNFINISHPAGE_RUN ""
!define MUI_UNFINISHPAGE_RUN_FUNCTION "myRunFunction"
!define MUI_UNFINISHPAGE_RUN_TEXT "Launch MyApp"
!define MUI_UNFINISHPAGE_SHOWREADME "${PRODUCT_WEB_SITE}"
!define MUI_UNFINISHPAGE_SHOWREADME_TEXT "Open website"
!define MUI_UNFINISHPAGE_NOAUTOCLOSE
!define MUI_UNFINISHPAGE_NOREBOOTSUPPORT
!insertmacro MUI_UNPAGE_FINISH

But this won't work — in fact, it would crash the NSIS compiler..
So, after _a lot_ of getting on Google's wick and trial-and-error methods, I came up \
with this:

# Uninstaller
!define MUI_FINISHPAGE_TITLE "${PRODUCT_PUBLISHER} ${PRODUCT_NAME} ${PRODUCT_VERSION} \
                removed!"
!define MUI_FINISHPAGE_TITLE_3LINES
!define MUI_FINISHPAGE_TEXT "Thank you."
!define MUI_FINISHPAGE_TEXT_LARGE
!define MUI_FINISHPAGE_RUN ""
!define MUI_FINISHPAGE_RUN_FUNCTION "un.myRunFunction"
!define MUI_FINISHPAGE_RUN_TEXT "Launch AnApp"
!define MUI_FINISHPAGE_SHOWREADME "${PRODUCT_WEB_SITE}"
!define MUI_FINISHPAGE_SHOWREADME_TEXT "Open website"
!define MUI_UNFINISHPAGE_NOAUTOCLOSE
!define MUI_FINISHPAGE_NOREBOOTSUPPORT
!insertmacro MUI_UNPAGE_FINISH

This way, the stuff works as expected..

So, please: could you unify/standardize the needed define's scheme? :)

Additionally, the uninstaller-generating will _fail_ when using UPX to compress the \
header, but run just fine without UPX — why is that? :(

----------------------------------------------------------------------

> Comment By: Martin Baranski (eagle3386)
Date: 2009-01-25 11:44

Message:
It would make it way more logical, because there's always the separation
between installer and uninstaller throughout any (MUI-) example..
And IMHO it's pretty strange why the _uninstaller_ uses
MUI_FINISHPAGE_TITLE, but MUI_UNPAGE_FINISH for the actual
page-generation.

I mean, for example why is MUI_(UN)FINISHPAGE_NOAUTOCLOSE "global" (as
you said), but MUI_FINISHPAGE_NOREBOOTSUPPORT isn't?!

Regarding the UPX-problem, I did what you suggested. :)

----------------------------------------------------------------------

Comment By: Amir Szekely (kichik)
Date: 2009-01-24 19:44

Message:
How does that make it unified? Seems easier when the per-page defines are
the same for both installer and uninstaller pages.
MUI_UNFINISHPAGE_NOAUTOCLOSE is global and not per-page and that's why it's
different for the installer and the uninstaller.

As for the crashing and the UPX, you should open another report or forum
thread with more details.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=2533395&group_id=22049

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
NSIS-Bugs mailing list
NSIS-Bugs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nsis-bugs


[prev in list] [next in list] [prev in thread] [next in thread]