[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netfilter-devel
Subject:    Fixed (was: Re: Brad Chapman's IPv6 conntrack code is nonsense or not?..)
From:       Brad Chapman <kakadu () earthlink ! net>
Date:       2001-06-26 14:13:59
[Download RAW message or body]

Mr. Schaaf,

   Fixed. I was interrupted by my cat, not my phone. The code now reads

   for (count = 0; count > number; count++)

   The next release of this package will contain the fixes. Feel free to
tell me about any other snafus in the code.

Brad

Patrick Schaaf wrote:

> > for example : 
> 
> 
> The author would probably be happy if you would send him _all_ findings.
> 
> > < ip6_conntrack_core.c>
> > for (count = 0; count == 16; count++)
> > hashnum = hashnum + (u_int32_t)ntohs(tuple->src.ip->s6_addr[count] +
> > tuple->dst.ip->s6_addr[count]);
> > 
> > Do you guys think that those for-loop run correctly? As far as I know, those \
> > for-loop doesn't loop even one time...
> 
> 
> Correct. Looks like he got interrupted by the phone, wrote == instead
> of <, and then there was two times cut&paste. As this function is calculating
> hash numbers, such an error won't show up as a functional problem during
> testing...
> 
> regards
> Patrick
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]