[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netfilter-devel
Subject:    Re: [PATCH nft] meta: introduce broute expression
From:       Florian Westphal <fw () strlen ! de>
Date:       2023-02-23 23:06:52
Message-ID: 20230223230652.GE26596 () breakpoint ! cc
[Download RAW message or body]

Sriram Yagnaraman <sriram.yagnaraman@est.tech> wrote:
>  static bool meta_key_is_unqualified(enum nft_meta_keys key)
> diff --git a/src/parser_bison.y b/src/parser_bison.y
> index 824e5db8..e3440b2b 100644
> --- a/src/parser_bison.y
> +++ b/src/parser_bison.y
> @@ -528,6 +528,7 @@ int nft_lex(void *, void *, void *);
>  %token OIFGROUP			"oifgroup"
>  %token CGROUP			"cgroup"
>  %token TIME			"time"
> +%token BROUTE 			"broute"

I think you don't need to add a new token.
meta_key_parse() should pick this up from the meta_template
array automatically.

> index bc5b5b62..f1ffa053 100644
> --- a/src/scanner.l
> +++ b/src/scanner.l
> @@ -721,6 +721,7 @@ addrstring	({macaddr}|{ip4addr}|{ip6addr})
>  "iifgroup"		{ return IIFGROUP; }
>  "oifgroup"		{ return OIFGROUP; }
>  "cgroup"		{ return CGROUP; }
> +"broute"		{ return BROUTE; }

and this should not be needed either.
[prev in list] [next in list] [prev in thread] [next in thread]