[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netfilter-devel
Subject:    Re: [PATCH nf-next 8/8] netfilter: conntrack: remove l3proto abstraction
From:       kbuild test robot <lkp () intel ! com>
Date:       2018-06-28 21:57:50
Message-ID: 201806290526.QO9g7IZp%fengguang.wu () intel ! com
[Download RAW message or body]

Hi Florian,

I love your patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-conntrack-remove-ctnetlink-callbacks-from-l3-protocol-trackers/20180629-053035
                
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: i386-randconfig-x070-201825 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   net/netfilter/nf_conntrack_proto.c: In function 'nf_ct_netns_do_put':
> > net/netfilter/nf_conntrack_proto.c:836:33: error: 'ipv6_conntrack_ops' undeclared \
> > (first use in this function); did you mean 'ipv4_conntrack_ops'?
       nf_unregister_net_hooks(net, ipv6_conntrack_ops,
                                    ^~~~~~~~~~~~~~~~~~
                                    ipv4_conntrack_ops
   net/netfilter/nf_conntrack_proto.c:836:33: note: each undeclared identifier is \
reported only once for each function it appears in  In file included from \
include/linux/kernel.h:15:0,  from include/linux/skbuff.h:17,
                    from include/linux/netfilter.h:6,
                    from net/netfilter/nf_conntrack_proto.c:4:
> > include/linux/build_bug.h:29:45: error: bit-field '<anonymous>' width not an \
> > integer constant
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
                                                ^
   include/linux/compiler-gcc.h:65:28: note: in expansion of macro \
'BUILD_BUG_ON_ZERO'  #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), \
&(a)[0]))  ^~~~~~~~~~~~~~~~~
   include/linux/kernel.h:72:59: note: in expansion of macro '__must_be_array'
    #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                                              ^~~~~~~~~~~~~~~
> > net/netfilter/nf_conntrack_proto.c:837:7: note: in expansion of macro \
> > 'ARRAY_SIZE'
          ARRAY_SIZE(ipv6_conntrack_ops));
          ^~~~~~~~~~
--
   net//netfilter/nf_conntrack_proto.c: In function 'nf_ct_netns_do_put':
   net//netfilter/nf_conntrack_proto.c:836:33: error: 'ipv6_conntrack_ops' undeclared \
(first use in this function); did you mean 'ipv4_conntrack_ops'?  \
nf_unregister_net_hooks(net, ipv6_conntrack_ops,  ^~~~~~~~~~~~~~~~~~
                                    ipv4_conntrack_ops
   net//netfilter/nf_conntrack_proto.c:836:33: note: each undeclared identifier is \
reported only once for each function it appears in  In file included from \
include/linux/kernel.h:15:0,  from include/linux/skbuff.h:17,
                    from include/linux/netfilter.h:6,
                    from net//netfilter/nf_conntrack_proto.c:4:
> > include/linux/build_bug.h:29:45: error: bit-field '<anonymous>' width not an \
> > integer constant
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
                                                ^
   include/linux/compiler-gcc.h:65:28: note: in expansion of macro \
'BUILD_BUG_ON_ZERO'  #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), \
&(a)[0]))  ^~~~~~~~~~~~~~~~~
   include/linux/kernel.h:72:59: note: in expansion of macro '__must_be_array'
    #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                                              ^~~~~~~~~~~~~~~
   net//netfilter/nf_conntrack_proto.c:837:7: note: in expansion of macro \
'ARRAY_SIZE'  ARRAY_SIZE(ipv6_conntrack_ops));
          ^~~~~~~~~~

vim +836 net/netfilter/nf_conntrack_proto.c

   822	
   823	static void nf_ct_netns_do_put(struct net *net, u8 nfproto)
   824	{
   825		struct nf_conntrack_net *cnet = net_generic(net, nf_conntrack_net_id);
   826	
   827		mutex_lock(&nf_ct_proto_mutex);
   828		switch (nfproto) {
   829		case NFPROTO_IPV4:
   830			if (cnet->users4 && (--cnet->users4 == 0))
   831				nf_unregister_net_hooks(net, ipv4_conntrack_ops,
   832							ARRAY_SIZE(ipv4_conntrack_ops));
   833			break;
   834		case NFPROTO_IPV6:
   835			if (cnet->users6 && (--cnet->users6 == 0))
 > 836				nf_unregister_net_hooks(net, ipv6_conntrack_ops,
 > 837							ARRAY_SIZE(ipv6_conntrack_ops));
   838			break;
   839		}
   840	
   841		mutex_unlock(&nf_ct_proto_mutex);
   842	}
   843	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


[".config.gz" (application/gzip)]
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]