[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netfilter-devel
Subject:    Re: [PATCH 2/3] netfilter: af_info: add 'strict' parameter to
From:       David Miller <davem () davemloft ! net>
Date:       2011-03-22 21:42:24
Message-ID: 20110322.144224.183070503.davem () davemloft ! net
[Download RAW message or body]

From: Florian Westphal <fw@strlen.de>
Date: Tue, 22 Mar 2011 22:26:39 +0100

> David Miller <davem@davemloft.net> wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Mon, 21 Mar 2011 23:42:59 +0100
>> 
>> > Ah sorry, I missed the "static const". Maybe I should just sleep now ;)
>> 
>> Well, I would really prefer if ip6_route_output() and friends mark
>> their 'sk' argument as 'const'.
>> 
>> Otherwise someone is going to read this code and be really concerned
>> that "sk" really might be modified in some way by this code path,
>> thus making parallel access to this static const 'sk' illegal.
> 
> good point.
> Its just a two-line change, so I guess its okay if I make this
> change in this patch, too.
> 
> If you object and think it should be a new patch, please let me
> know.

Please make the ipv6 route interface change seperate, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]