[prev in list] [next in list] [prev in thread] [next in thread]
List: netfilter
Subject: Re: [PATCH 6/7] net/netfilter/nfnetlink_log.c: fix error return code
From: Pablo Neira Ayuso <pablo () netfilter ! org>
Date: 2012-08-30 1:35:33
Message-ID: 20120830013533.GE8878 () 1984
[Download RAW message or body]
On Wed, Aug 29, 2012 at 06:49:17PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Initialize return variable before exiting on an error path.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
>
> // </smpl>
And also applied, thanks Julia. I'll pass these to current -rc.
--
To unsubscribe from this list: send the line "unsubscribe netfilter" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic