[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netcf-devel
Subject:    [netcf-devel] Fix to allow definitions with multiple ipv4 addresses for arp monitoring
From:       eblake () redhat ! com (Eric Blake)
Date:       2011-11-30 16:00:23
Message-ID: 4ED65317.4040404 () redhat ! com
[Download RAW message or body]

On 10/31/2011 08:08 AM, Jens Nyberg I wrote:
> Hi!

Hello, and sorry for the delayed reply.

> This might not be the correct solution so please advice me on how to further improve this

> +++ interface.rng.new   2011-10-31 14:56:36.000000000 +0100
> @@ -202,7 +202,7 @@
>            </element>
>            <element name="arpmon">
>              <attribute name="interval"><ref name="uint"/></attribute>
> -            <attribute name="target"><ref name="ipv4-addr"/></attribute>
> +            <attribute name="target"><ref name="ipv4-multi-addr"/></attribute>

Using comma-separated values in XML is a bad idea - it means you can't
use XPath expressions to get at each IP address.  See this thread [1] in
libvirt that had the same complaint; the solution that was used there
was to instead enhance the XML to take multiple elements, one per IP
address.

[1] https://www.redhat.com/archives/libvir-list/2011-October/msg01105.html

The idea of supporting multiple addresses has merit, but we need to
re-think the XML appropriate for expressing it.

I'm not the normal netcf maintainer, so I'll let Laine speak to your
other patch.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
Url : https://fedorahosted.org/pipermail/netcf-devel/attachments/20111130/14658ac2/attachment.bin 

[prev in list] [next in list] [prev in thread] [next in thread]