[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netcf-devel
Subject:    [netcf-devel] [PATCH 08/11] Add test case for Suse driver
From:       laine () laine ! org (Laine Stump)
Date:       2011-09-22 17:51:01
Message-ID: 4E7B7585.2080309 () laine ! org
[Download RAW message or body]

On 09/21/2011 12:50 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"<berrange at redhat.com>
>
> This clones the Red Hat driver test case for Suse. This test suite does
> not pass as it stands
> ---
>   tests/suse/fsroot/etc/sysconfig/iptables           |   12 +
[...]

>   .../fsroot/etc/sysconfig/system-config-firewall    |    5 +
>   .../proc/sys/net/bridge/bridge-nf-call-iptables    |    1 +

You shouldn't need the above three files, since they were only used to 
test the iptables manipulation, which no longer exists.

Otherwise ACK - as you say, it's better to have it in as it is than not 
at all!

[prev in list] [next in list] [prev in thread] [next in thread]