[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netbsd-tech-pkg
Subject:    Re: replace target with OBJ on nfs, fix root creation of files
From:       Greg Troxel <gdt () lexort ! com>
Date:       2019-01-20 1:59:47
Message-ID: smu1s589jho.fsf () linuxpal ! mit ! edu
[Download RAW message or body]



Roy Marples <roy@marples.name> writes:

> Index: install/replace.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mk/install/replace.mk,v
> retrieving revision 1.18
> diff -u -p -r1.18 replace.mk
> --- install/replace.mk	10 Apr 2016 15:58:02 -0000	1.18
> +++ install/replace.mk	19 Jan 2019 23:41:16 -0000
> @@ -29,6 +29,7 @@ _REPLACE_TARGETS+=	package
>  .endif
>  _REPLACE_TARGETS+=	replace-message
>  _REPLACE_TARGETS+=	unprivileged-install-hook
> +_REPLACE_TARGETS+=	replace-names
>  
>  #
>  # replace

That seems ok, but I wonder if we need to comment or otherwise document
any ordering that is implied by the various REPLACE_TARGET values, which
I would have thought of as a set more than an ordered list.

Conceptually, moving the resolution of names to outside of the $SU_CMD
seems fine.
[prev in list] [next in list] [prev in thread] [next in thread]