[prev in list] [next in list] [prev in thread] [next in thread]
List: netbsd-tech-kern
Subject: Re: GSoC-2016
From: christos () zoulas ! com (Christos Zoulas)
Date: 2016-06-10 21:23:18
Message-ID: 20160610212318.1818017FDAC () rebar ! astron ! com
[Download RAW message or body]
On Jun 10, 11:44pm, hrishi.goyal@gmail.com (HRISHIKESH GOYAL) wrote:
-- Subject: Re: GSoC-2016
> Hello sir,
>
> I am working on Htree directory index traversing in lookup() operation. I
> am facing difficulty in testing of Htree index code. I see the control
> never goes to Htree index traversal code because the value
> (i_flag&EXT4_INDEX) is false in the Ext4 disk image created by Htree
> indexing for directory enabled Linux's Ext4fs driver.
> Since index follows the link list indexing within a block I created 800
> files to make sure that it gets overflow the 4 kb block and Htree gets
> created. I m not able to figure out why directory index is still link list
> type. Or if it is not then why (i_flag&EXT4_INDEX) value is false.
> Regards
> Hrishikesh
The code that determines if the directory needs indexing is:
http://lxr.free-electrons.com/source/fs/ext4/dir.c?v=4.1#L39
It would be useful to run a linux kernel on another VM and put printfs
in the ext code to see when that function returns true...
Or you can keep creating more files :-) Eventually it will probably
decide to index if the other conditionals are true.
christos
>
> On Sun, Jun 5, 2016 at 8:09 PM, Christos Zoulas <christos@zoulas.com> wrote:
>
> > On Jun 5, 7:44am, hrishi.goyal@gmail.com (HRISHIKESH GOYAL) wrote:
> > -- Subject: Re: GSoC-2016
> >
> > > Hello sir,
> > > I started doing Htree directory index, albeit some improvements in
> > > 'extents' are yet to be done. But those can be handled afterwards as I
> > have
> > > clear understanding of where and what is to be added/fixed. If you have
> > > some other plan for me then please let me know. I will do the job
> > > accordingly.
> > > Regards
> > > Hrishikesh
> >
> > No, I don't have any other plan. As you've seen I've committed the extents
> > changes (please take a look on my minor changes). Also we already got one
> > happy user who said in the mailing lists he was happy you implemented them.
> > As always please let me know if you need anything.
> >
>
> Yes I have looked at the minor changes you made. I will follow NetBSD
> standard from now onwards.
>
>
>
> >
>
> Good luck,
> >
> > christos
> >
>
> --001a113d65ca33c3610534f083ff
> Content-Type: text/html; charset=UTF-8
> Content-Transfer-Encoding: quoted-printable
>
> <p dir="ltr">Hello sir,</p>
> <p dir="ltr">I am working on Htree directory index traversing in lo| okup() \
> operation. I am facing difficulty in testing of Htree index co| de. I see the \
> control never goes to Htree index traversal code because the | value \
> (i_flag&EXT4_INDEX) is false in the Ext4 disk image created by Ht| ree indexing \
> for directory enabled Linux's Ext4fs driver.<br>
> Since index follows the link list indexing within a block I created 800 fil| es to \
> make sure that it gets overflow the 4 kb block and Htree gets created| . I m not \
> able to figure out why directory index is still link list type. O| r if it is not \
> then why (i_flag&EXT4_INDEX) value is false.<br>
> Regards<br>
> Hrishikesh</p>
> <p><DEFANGED_div class="gmail_quot<blockquote class=" style="margi| n:0 0 0 \
> .8ex;border-left:1px #ccc solid;padding-left:1ex"><p><DEFANGED_div | \
> dir="ltr"><p><DEFANGED_div class="gmail_extra"><br><p><DEFANGED_div cla| \
> ss="gmail_quote">On Sun, Jun 5, 2016 at 8:09 PM, Christos Zoulas <DEFANGE| D_span \
> dir="ltr"><<a href="mailto:christos@zoulas.com" target="_bl| \
> ank">christos@zoulas.com</a>></DEFANGED_span> wrote:<br><blockquote clas| \
> s="gmail_quote" DEFANGED_style="margin:0px 0px 0px 0.8ex;border-left:1p| x solid \
> rgb(204,204,204);padding-left:1ex"><DEFANGED_span>On Jun 5, 7| :44am, <a \
> href="mailto:hrishi.goyal@gmail.com" target="_blank">hrishi.g| oyal@gmail.com</a> \
> (HRISHIKESH GOYAL) wrote:<br>
> -- Subject: Re: GSoC-2016<br>
> <br>
> > Hello sir,<br>
> </DEFANGED_span><DEFANGED_span>| I started doing Htree directory index, alb| eit \
> some improvements in<br>
> > 'extents' are yet to be done. But those can be handled afterwards| as I \
> > have<br>
> > clear understanding of where and what is to be added/fixed. If you have<b| r>
> > some other plan for me then please let me know. I will do the job<br>
> > accordingly.<br>
> > Regards<br>
> > Hrishikesh<br>
> <br>
> </DEFANGED_span>No, I don't have any other plan. As you've seen I&#| 39;ve \
> committed the extents<br>
> changes (please take a look on my minor changes). Also we already got one<b| r>
> happy user who said in the mailing lists he was happy you implemented them.| <br>
> As always please let me know if you need anything.<br></blockquote><p><DEFA| \
> NGED_div><br>Yes I have looked at the minor changes you made. I will follow| \
> NetBSD standard from now onwards.<br><br> </p><DEFANGED_div><blockquo| te \
> class="gmail_quote" DEFANGED_style="margin:0px 0px 0px 0.8ex;border-| left:1px \
> solid rgb(204,204,204);padding-left:1ex">
> </blockquote><blockquote class="gmail_quote" DEFANGED_style="marg| in:0px 0px 0px \
> 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e| x">
> Good luck,<br>
> <br>
> christos<br>
> </blockquote></p><DEFANGED_div><br></p><DEFANGED_div></p><DEFANGED_div>
> </p><DEFANGED_div>
>
> --001a113d65ca33c3610534f083ff--
>
> --MIMEStream=_0+101145_9380720988921_49487885396
> Content-Type: text/sanitizer-log; charset="iso-8859-1"
> Content-Transfer-Encoding: 8bit
> Content-Disposition: attachment; filename="sanitizer.log"
>
> This message has been 'sanitized'. This means that potentially
> dangerous content has been rewritten or removed. The following
> log describes which actions were taken.
>
> Sanitizer (start="1465582484"):
> Forcing message to be multipart/mixed, to facilitate logging.
> Writer (pos="3339"):
> Part (pos="3388"):
> Part (pos="107"):
> SanitizeFile (filename="unnamed.txt", mimetype="text/plain"):
> Match (names="unnamed.txt", rule="9"):
> Enforced policy: accept
>
> Part (pos="1780"):
> SanitizeFile (filename="unnamed.html, filetype.html", mimetype="text/html"):
> Match (names="unnamed.html, filetype.html", rule="9"):
> Enforced policy: accept
>
> Note: Styles and layers give attackers many tools to fool the
> user and common browsers interpret Javascript code found
> within style definitions.
>
> Rewrote HTML tag: >>_div class="gmail_quot<blockquote class=" style="margin:0 0 \
> 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"_<<
> as: >>_p__DEFANGED_div class="gmail_quot<blockquote class=" style="margin:0 0 0 \
> .8ex;border-left:1px #ccc solid;padding-left:1ex"_<<
> Rewrote HTML tag: >>_div dir="ltr"_<<
> as: >>_p__DEFANGED_div dir="ltr"_<<
> Rewrote HTML tag: >>_div class="gmail_extra"_<<
> as: >>_p__DEFANGED_div class="gmail_extra"_<<
> Rewrote HTML tag: >>_div class="gmail_quote"_<<
> as: >>_p__DEFANGED_div class="gmail_quote"_<<
> Rewrote HTML tag: >>_span dir="ltr"_<<
> as: >>_DEFANGED_span dir="ltr"_<<
> Rewrote HTML tag: >>_/span_<<
> as: >>_/DEFANGED_span_<<
> Rewrote HTML tag: >>_blockquote class="gmail_quote" style="margin:0px 0px 0px \
> 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"_<<
> as: >>_blockquote class="gmail_quote" DEFANGED_style="margin:0px 0px 0px \
> 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"_<<
> Rewrote HTML tag: >>_span_<<
> as: >>_DEFANGED_span_<<
> Rewrote HTML tag: >>_/span_<<
> as: >>_/DEFANGED_span_<<
> Rewrote HTML tag: >>_span_<<
> as: >>_DEFANGED_span_<<
> Rewrote HTML tag: >>_/span_<<
> as: >>_/DEFANGED_span_<<
> Rewrote HTML tag: >>_div_<<
> as: >>_p__DEFANGED_div_<<
> Rewrote HTML tag: >>_/div_<<
> as: >>_/p__DEFANGED_div_<<
> Rewrote HTML tag: >>_blockquote class="gmail_quote" style="margin:0px 0px 0px \
> 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"_<<
> as: >>_blockquote class="gmail_quote" DEFANGED_style="margin:0px 0px 0px \
> 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"_<<
> Rewrote HTML tag: >>_blockquote class="gmail_quote" style="margin:0px 0px 0px \
> 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"_<<
> as: >>_blockquote class="gmail_quote" DEFANGED_style="margin:0px 0px 0px \
> 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"_<<
> Rewrote HTML tag: >>_/div_<<
> as: >>_/p__DEFANGED_div_<<
> Rewrote HTML tag: >>_/div_<<
> as: >>_/p__DEFANGED_div_<<
> Rewrote HTML tag: >>_/div_<<
> as: >>_/p__DEFANGED_div_<<
> Rewrote HTML tag: >>_/div_<<
> as: >>_/p__DEFANGED_div_<<
>
> Total modifications so far: 19
>
>
> Anomy 0.0.0 : Sanitizer.pm
> $Id: Sanitizer.pm,v 1.94 2006/01/02 16:43:10 bre Exp $
>
> --MIMEStream=_0+101145_9380720988921_49487885396--
-- End of excerpt from HRISHIKESH GOYAL
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic