[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netbsd-tech-kern
Subject:    Re: Making global variables of if.c MPSAFE
From:       Hisashi T Fujinaka <htodd () twofifty ! com>
Date:       2014-07-30 14:49:03
Message-ID: alpine.NEB.2.11.1407300748370.3484 () chris ! i8u ! org
[Download RAW message or body]

On Wed, 30 Jul 2014, Ryota Ozaki wrote:

> On Wed, Jul 30, 2014 at 6:40 AM, Hisashi T Fujinaka <htodd@twofifty.com> wrote:
>>  On 26 Jul, 2014, at 22:38 , Ryota Ozaki <ozaki-r@netbsd.org> wrote:
>>>
>>> The global variables are read-mostly, so I replace the mutex with a
>>> rwlock and use it for all. Unfortunately, ifnet_list may be accessed
>>> from interrupt context (only read though) so that I add a spin mutex
>>> for it; we hold the mutex when we modify ifnet_list as well as the
>>> rwlock.
>>
>>
>> This breaks BEAGLEBOARDXM, btw.
>
> I'm sorry for the breakage. (Though the criminal is another patch of mine.)
>
> Here is a patch: http://www.netbsd.org/~ozaki-r/ethersubr_bigpktpps_fix.diff
> I'll commit it if it's appropriate.
>
> Thanks for your report,

It fixed my build, thanks.

-- 
Hisashi T Fujinaka - htodd@twofifty.com
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
[prev in list] [next in list] [prev in thread] [next in thread]