[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netbsd-tech-kern
Subject:    Re: Retackling NEW_VMCMD()
From:       Matt Thomas <matt () 3am-software ! com>
Date:       2003-08-28 16:06:27
[Download RAW message or body]

On Thursday, August 28, 2003, at 02:55 AM, Bang Jun-Young wrote:
> Hi, this is another story. :-)
>
> Currently, NEW_VMCMD() is only expanded to a real function new_vmcmd()
> if DEBUG is defined. For the normal case, it's expanded inline. But it 
> is
> never called within a performance-critical loop, so inlining it gives 
> no
> advantanges but a bigger kernel.
>
> By removing DEBUG & macro stuff and always calling new_vmcmd(), I could
> save a bunch of kernel size, approx. 4kB:
>
> -rwxr-xr-x  1 junyoung  junyoung  6854276 Aug 28 17:26 netbsd
> -rwxr-xr-x  1 junyoung  junyoung  6858538 Aug 28 13:02 netbsd.old

Commit!  Commit!  :)

I'll support almost anything that's anti-bloat and doesn't hurt 
performance.
-- 
Matt Thomas                     email: matt@3am-software.com
3am Software Foundry              www: 
http://3am-software.com/bio/matt/ Cupertino, CA              
disclaimer: I avow all knowledge of this message.

[prev in list] [next in list] [prev in thread] [next in thread]