[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netbsd-port-xen
Subject:    Re: NetBSD guests won't boot with netbsd-9 DOM0
From:       Jaromír Doleček <jaromir.dolecek () gmail ! com>
Date:       2019-10-16 19:12:33
Message-ID: CAMnsW569Dv93LCGbsbg9BiZXGmoMibCu-xBHPgzEx2vP7_rKSg () mail ! gmail ! com
[Download RAW message or body]

Le mer. 16 oct. 2019 =C3=A0 21:04, Michael van Elst <mlelstv@serpens.de> a =
=C3=A9crit :
>
> On Wed, Oct 16, 2019 at 03:59:36PM +0200, Jarom=C3=ADr Dole?ek wrote:
>
> > This should fix it, different way than cgd in kern/41704:
> > https://www.netbsd.org/~jdolecek/xbd_disklabel_fix.diff
>
> sc_dksc.sc_dev is a device_t (pointer to device structure) not
> a dev_t (device/unit/partition number).
>
> These error messages also came from the guest which seems to be
> a netbsd-8 or older.
>
> On the other hand a dev_t of 0 is wd0a, this shouldn't exist on
> a PVM guest and you should get a default label, and not something
> that reflects the geometry of xbd0.
>
> In any case, reading the disklabel in this place is wrong and
> can just be dropped. The disklabel is read in the open routine
> and has a specific semantic there.

Indeed - I've looked at this in more detail and found exactly that.
The call should be just dropped. I'm currently testing the change, if
it by chance has any unintended consequence.

Jaromir
[prev in list] [next in list] [prev in thread] [next in thread]