[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netbsd-port-amd64
Subject:    Re: [PATCH] Add intr_mask() / intr_unmask() interface to mask / unmask individual interrupt sources
From:       Jason Thorpe <thorpej () me ! com>
Date:       2019-11-30 23:17:37
Message-ID: 9AB9BF05-7953-4AEF-8C43-B50FE6C5A922 () me ! com
[Download RAW message or body]



> On Nov 30, 2019, at 3:07 PM, Jason Thorpe <thorpej@me.com> wrote:
> 
> So I think these are already safely serialized, although I could add an extra \
> measure of safety by disabling interrupts on the current CPU around those 3 lines \
> of code to make absolutely sure that cross-call doesn't arrive until we're done.

Yah, on second thought, I don't think I will add that additional code... as far as I \
can tell, it's completely unnecessary (because it's all already serialized with \
cpu_lock) and would only add confusion.  I will add a comment about the mask count \
being protected with cpu_lock, however.

-- thorpej


[prev in list] [next in list] [prev in thread] [next in thread]