[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netbsd-current-users
Subject:    Re: CTL_*_NAMES macros
From:       Masanobu SAITOH <msaitoh () execsw ! org>
Date:       2018-08-22 1:50:10
Message-ID: c17c122a-a727-6f15-c512-fe068dc0ed63 () execsw ! org
[Download RAW message or body]

rjs@ wrote:
> 
> Masanobu SAITOH <masanobu@iij.ad.jp> wrote:
>> % egrep -r 'CTL_.*_NAMES' .
>> ./sys/arch/m68k/include/sysctl.h:#ifndef CTL_MACHDEP_NAMES
>> ./sys/arch/m68k/include/sysctl.h:#endif /* CTL_MACHDEP_NAMES */
> 
> These are not examples of sysctl counter names, they are just the
> multiple inclusion prevention symbols for that file.

In reality, CTL_MACHDEP_NAMES was not defined from anywhere :(
I cleaned up the m68k's CPU_* macros for CTL_MACHDEP sysctl
by moving them into m68k/include/cpu.h


On 2018/08/11 17:39, Christos Zoulas wrote:
> In article <41393cac-bf42-08dd-da98-4d4fabbd5d2e@execsw.org>,
> Masanobu SAITOH  <msaitoh@execsw.org> wrote:
> 
>>> Are these required?
>>> Are these maintained?
>>> Can we remove these macros?
>>>
>>> The following changes are related:
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138991.html
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138992.html
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138993.html
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138994.html
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138995.html
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138996.html
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138997.html
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138998.html
>>> http://mail-index.netbsd.org/source-changes/2003/12/04/msg138999.html
>>
>> It seems FreeBSD removed those macros in the following commit:
>>
>> 	https://svnweb.freebsd.org/base?view=revision&revision=254925
>>
> 
> Let's remove them.

  Done!

> christos
> 


-- 
-----------------------------------------------
                 SAITOH Masanobu (msaitoh@execsw.org
                                  msaitoh@netbsd.org)
[prev in list] [next in list] [prev in thread] [next in thread]