[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netbsd-current-users
Subject:    Re: Build failure - XEN kernels - identcpu.c
From:       Paul Goyette <paul () whooppee ! com>
Date:       2009-04-30 3:52:21
Message-ID: Pine.NEB.4.64.0904292050540.2807 () quicky ! whooppee ! com
[Download RAW message or body]

On Wed, 29 Apr 2009, Paul Goyette wrote:

> Sources updated 2009-04-30 01:29:18 UTC
>
> Getting the following errors while linking amd64/kern-XEN3_DOMU and 
> i386/kern-INSTALL_XEN3PAE_DOMU
>
>
> identcpu.o: In function `cpu_probe':
> identcpu.c:(.text+0x93c): undefined reference to `x86_cpu_toplogy'
>
> Looks like a typo? -------------------------------^^^^^^^^^^^^^^^
> Missing an 'o'?

Nope, I checked, and the spelling is correct!

However, it seems that the x86_cpu_topology.c file is not included in 
xen builds.  I think the following patch fixes this problem;  I'll 
commit it as soon as I verify that it fixes the build, unless someone 
has an objection.

cvs diff: Diffing .
Index: files.xen
===================================================================
RCS file: /cvsroot/src/sys/arch/xen/conf/files.xen,v
retrieving revision 1.98
diff -u -p -r1.98 files.xen
--- files.xen   18 Apr 2009 11:26:58 -0000      1.98
+++ files.xen   30 Apr 2009 03:50:29 -0000
@@ -130,6 +130,7 @@ file        arch/x86/x86/sys_machdep.c
  file   arch/x86/x86/tsc.c
  file   arch/x86/x86/vm_machdep.c
  file   arch/x86/x86/x86_machdep.c
+file   arch/x86/x86/x86_cpu_topology.c

  include        "arch/xen/conf/files.compat"




-------------------------------------------------------------------------
|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:      |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul at whooppee.com   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------
[prev in list] [next in list] [prev in thread] [next in thread]