[prev in list] [next in list] [prev in thread] [next in thread] 

List:       netatalk-devel
Subject:    Re: [Netatalk-devel] [PATCH] fix some memory / resource leaks
From:       Riccardo Magliocchetti <riccardo.magliocchetti () gmail ! com>
Date:       2011-11-30 14:43:21
Message-ID: 4ED64109.9080800 () gmail ! com
[Download RAW message or body]

Hi,

Il 30/11/2011 14:31, Frank Lahm ha scritto:
> Hi Ricardo,
>
> 2011/11/29 Riccardo Magliocchetti<riccardo.magliocchetti@gmail.com>:
>> attached a few patches that fix errors reported by running "cppcheck -f ."
>> from netatalk root dir. There are a lot more and from looking at the code
>> the are a lot more leaks not found by cppcheck.
>
> Probably not. I've been checking this with Valgrind and libumem.

Most if not all of these issues are on error paths, so it may be 
difficult to catch at runtime.

>> Please review, compile tested only.
>
> Reviewed and committed in f9a95c8. Thanks!
>
>>  From looking at the code some stuff really could use some love, e.g. in
>> etc/afpd/afp_asp.c::afp_authprint_remove() open() is not even checked for
>> failure, the nested ifs are painful to follow. Same issues are in
>> etc/papd/lp.c.
>
> This is AppleTalk stuff which is not even compiled by default. I'd
> ignore it. I have it all axed out on Netatalk Next.

nice :)

thanks
riccardo

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Netatalk-devel mailing list
Netatalk-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/netatalk-devel
[prev in list] [next in list] [prev in thread] [next in thread]