[prev in list] [next in list] [prev in thread] [next in thread] 

List:       net-snmp-patches
Subject:    [Net-snmp-patches] [ net-snmp-Patches-3057090 ] Add support for
From:       "SourceForge.net" <noreply () sourceforge ! net>
Date:       2011-08-04 17:21:31
Message-ID: E1Qp1bw-0004Gg-MM () sfs-ml-3 ! v29 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Patches item #3057090, was opened at 2010-08-31 17:26
Message generated for change (Settings changed) made by hardaker
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312694&aid=3057090&group_id=12694

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
>Priority: 4
Private: No
Submitted By: Stephen Hemminger (shemminger)
Assigned to: Wes Hardaker (hardaker)
Summary: Add support for ethtool speed_hi

Initial Comment:
Change the use of Linux ethtool interface to match current
conventions used by the ethtool utility:
  * allow any reported value for speed
  * use ethtool conventions for speed unknown (0 or ffff)
  * if device reports unknown speed, don't call MII
  * support 32 bits speed data, necessary for 100G
    This is newish so need to add autoconf foo to handle it.

----------------------------------------------------------------------

Comment By: Wes Hardaker (hardaker)
Date: 2010-11-30 14:22

Message:
well, it turns out that this doesn't work on centos 5.5.  Niels found
problems:


> #ifdef HAVE_LINUX_ETHTOOL_H
> #ifndef HAVE_PCI_LOOKUP_NAME
> #include <linux/types.h>
> typedef __u64 u64;         /* hack, so we may include kernel's ethtool.h
*/
> typedef __u32 u32;         /* ditto */
> typedef __u16 u16;         /* ditto */
> typedef __u8 u8;           /* ditto */
> #endif
>
> #include <linux/ethtool.h>
> #endif /* HAVE_LINUX_ETHTOOL_H */

configure set both HAVE_LINUX_ETHTOOL_H and HAVE_PCI_LOOKUP_NAME but 
<linux/ethtool.h> uses __u64 etc. as its member types, not u64 as this 
sequence implies, and the __u64 set is not declared.


----------------------------------------------------------------------

Comment By: Wes Hardaker (hardaker)
Date: 2010-11-29 21:56

Message:
Thanks for the patch!  It has been applied to the 5.5.x code branch and the
main development tree, and will appear in future releases of the Net-SNMP
package.

----------------------------------------------------------------------

Comment By: Leonardo Chiquitto (lchiquitto)
Date: 2010-11-26 05:04

Message:
I tested this patch with a tweaked driver that simulates 100G speeds and it
worked fine.
Please, is it possible to commit it to trunk and v5-6-patches? Thanks.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312694&aid=3057090&group_id=12694

------------------------------------------------------------------------------
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts. 
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Net-snmp-patches mailing list
Net-snmp-patches@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-patches
[prev in list] [next in list] [prev in thread] [next in thread]