[prev in list] [next in list] [prev in thread] [next in thread] 

List:       net-snmp-coders
Subject:    Re: SF.net SVN: net-snmp:[18064] trunk/net-snmp
From:       Magnus Fromreide <magfr () lysator ! liu ! se>
Date:       2010-01-25 21:17:40
Message-ID: 1264454260.1910.21.camel () sara ! home
[Download RAW message or body]

On Mon, 2010-01-25 at 16:01 +0000, rstory@users.sourceforge.net wrote:
> Revision: 18064
>           http://net-snmp.svn.sourceforge.net/net-snmp/?rev=18064&view=rev
> Author:   rstory
> Date:     2010-01-25 16:01:45 +0000 (Mon, 25 Jan 2010)
> 
> Log Message:
> -----------
> move snmp_get_statistic helper to helpers dir; update all_helpers header

I have to question this.

The reason I originally had to put it in mibgroup/utilities and not put
the header under include/ was that it is so specialized it is utterly
unusable for anything save mib modules that export internal statistics
variables, so why build it if no such module is built?

Further the reason to not put the header under include/ was to clearly
mark this as a not exported interface - this is an implementation
detail.

I thought agent/helpers were for generally useful helpers and this one
hardly ranks among them.

By the way, why put the range check in the handler instead of the
registration function and then let the scalar_group helper handle the
range checking?

/MF

> Modified Paths:
> --------------
>     trunk/net-snmp/include/net-snmp/agent/all_helpers.h
> 
> Added Paths:
> -----------
>     trunk/net-snmp/agent/helpers/snmp_get_statistic.c
>     trunk/net-snmp/include/net-snmp/agent/snmp_get_statistic.h
> 
> Removed Paths:
> -------------
>     trunk/net-snmp/agent/mibgroup/utilities/snmp_get_statistic.c
>     trunk/net-snmp/agent/mibgroup/utilities/snmp_get_statistic.h



------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
[prev in list] [next in list] [prev in thread] [next in thread]