'Re: [Nepomuk] Review Request 110354: Officially require the shared-desktop-ontologies version that a'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    Re: [Nepomuk] Review Request 110354: Officially require the shared-desktop-ontologies version that a
From:       "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date:       2013-05-08 10:28:24
Message-ID: 20130508102824.11643.84134 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110354/
-----------------------------------------------------------

(Updated May 8, 2013, 10:28 a.m.)

Status
------

This change has been marked as submitted.

Review request for Nepomuk, Ignacio Serantes and Vishesh Handa.

Description
-------

Actually I think that commit 79354558e6651946467656a4f0812f0e19381b51 should be \
reverted because relying on unreleased SDO versions always causes pain and suffering. \
Distro packages used to be sufficient for years, so people aren't used to SDO master \
being required anymore. If 7935... is going to be kept, I suggest that the patch \
posted here is merged.

Planned commit message:

Require shared-desktop-ontologies 0.10.51.

This should have been in 79354558e6651946467656a4f0812f0e19381b51.
Without explicitly requiring the version, the build will fail with the
not too helpful error message that NMM::albumArtist is missing.

Diffs
-----

  CMakeLists.txt 26facb7 

Diff: http://git.reviewboard.kde.org/r/110354/diff/

Testing
-------

The build fails as it should with distro SDO (0.10.0) and works with SDO master \
(0.10.51).

Thanks,

Andreas Hartmetz

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110354/">http://git.reviewboard.kde.org/r/110354/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk, Ignacio Serantes and Vishesh Handa.</div>
<div>By Andreas Hartmetz.</div>

<p style="color: grey;"><i>Updated May 8, 2013, 10:28 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Actually I think that commit 79354558e6651946467656a4f0812f0e19381b51 \
should be reverted because relying on unreleased SDO versions always causes pain and \
suffering. Distro packages used to be sufficient for years, so people aren&#39;t used \
to SDO master being required anymore. If 7935... is going to be kept, I suggest that \
the patch posted here is merged.

Planned commit message:

Require shared-desktop-ontologies 0.10.51.

This should have been in 79354558e6651946467656a4f0812f0e19381b51.
Without explicitly requiring the version, the build will fail with the
not too helpful error message that NMM::albumArtist is missing.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The build fails as it should with distro SDO (0.10.0) and works with SDO \
master (0.10.51).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(26facb7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110354/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 