'Re: [Nepomuk] Review Request 108916: Refactor nepomuk-simpleresource-rygen.py'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    Re: [Nepomuk] Review Request 108916: Refactor nepomuk-simpleresource-rygen.py
From:       "Sebastian Trueg" <sebastian () trueg ! de>
Date:       2013-02-12 10:40:17
Message-ID: 20130212104017.18240.27751 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108916/#review27277
-----------------------------------------------------------

I am totally fine with this. I was not aware of the bad performance of this script. \
Happy to see you improved it this significantly. However, I would like Vishesh to \
give the final ok.

- Sebastian Trueg

On Feb. 12, 2013, 10:32 a.m., Jörg Ehrichs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108916/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 10:32 a.m.)
> 
> 
> Review request for Nepomuk, Sebastian Trueg and Vishesh Handa.
> 
> 
> Description
> -------
> 
> To reduce to time necessary for large SimpelResource class generation for
> any application that needs more than a few ontologies.
> 
> This patch removes most calls to soprano and uses internal dictionary
> handling to generate the classes. Thus the class generation for the
> Nepomuk-WebMiner is down from ~25min to less than a second.
> 
> Instead of asking soprano for the properties/range etc of a class
> the output of the Soprano parser is used directly.
> 
> 
> Diffs
> -----
> 
> services/storage/rcgen/nepomuk-simpleresource-rcgen.py d2a4e0c 
> 
> Diff: http://git.reviewboard.kde.org/r/108916/diff/
> 
> 
> Testing
> -------
> 
> Class output for Nepomuk-WebMiner is exactly the same just faster.
> 
> 
> Thanks,
> 
> Jörg Ehrichs
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108916/">http://git.reviewboard.kde.org/r/108916/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am totally fine with \
this. I was not aware of the bad performance of this script. Happy to see you \
improved it this significantly. However, I would like Vishesh to give the final \
ok.</pre>  <br />

<p>- Sebastian</p>

<br />
<p>On February 12th, 2013, 10:32 a.m. UTC, Jörg Ehrichs wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk, Sebastian Trueg and Vishesh Handa.</div>
<div>By Jörg Ehrichs.</div>

<p style="color: grey;"><i>Updated Feb. 12, 2013, 10:32 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To reduce to time necessary for large SimpelResource class generation \
for any application that needs more than a few ontologies.

This patch removes most calls to soprano and uses internal dictionary
handling to generate the classes. Thus the class generation for the
Nepomuk-WebMiner is down from ~25min to less than a second.

Instead of asking soprano for the properties/range etc of a class
the output of the Soprano parser is used directly.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Class output for Nepomuk-WebMiner is exactly the same just faster.</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>services/storage/rcgen/nepomuk-simpleresource-rcgen.py <span style="color: \
grey">(d2a4e0c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108916/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 