'Re: [Nepomuk] Review Request 108773: Simple Plugin System for the NepomukCleaner'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    Re: [Nepomuk] Review Request 108773: Simple Plugin System for the NepomukCleaner
From:       "Sebastian Trueg" <sebastian () trueg ! de>
Date:       2013-02-05 13:50:41
Message-ID: 20130205135041.30366.67382 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Feb. 5, 2013, 1:33 p.m., Vishesh Handa wrote:
> > Do you think it would be better if we clubbed the CleaningJob in the nepomukcore \
> > library? Or should we really have this other cleaning library?

I think it should be separate since in an ideal world this tool would never be \
required. it is more of a high-level hack.

- Sebastian

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108773/#review26692
-----------------------------------------------------------

On Feb. 4, 2013, 3:46 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108773/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2013, 3:46 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> This patch adds a simple plugin-system to the NepomukCleaner allowing other \
> applications to install Nepomuk2::CleaningJobs whcih are run in addition to the \
> default jobs. 
> 
> Diffs
> -----
> 
> cleaner/CMakeLists.txt af7f94b 
> cleaner/cleaningjob.h PRE-CREATION 
> cleaner/cleaningjob.cpp PRE-CREATION 
> cleaner/cleaningjobs.h e17bdfe 
> cleaner/cleaningjobs.cpp 05addda 
> cleaner/jobmodel.h a7b0618 
> cleaner/jobmodel.cpp 8aadc83 
> cleaner/nepomukcleaningjob.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108773/diff/
> 
> 
> Testing
> -------
> 
> Implemented two CleaningJobs for TV shows - works fine.
> 
> 
> Thanks,
> 
> Sebastian Trueg
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108773/">http://git.reviewboard.kde.org/r/108773/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 5th, 2013, 1:33 p.m. UTC, <b>Vishesh \
Handa</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do you think it would be better if we clubbed the CleaningJob in the \
nepomukcore library? Or should we really have this other cleaning library?</pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it should be \
separate since in an ideal world this tool would never be required. it is more of a \
high-level hack.</pre> <br />

<p>- Sebastian</p>

<br />
<p>On February 4th, 2013, 3:46 p.m. UTC, Sebastian Trueg wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk.</div>
<div>By Sebastian Trueg.</div>

<p style="color: grey;"><i>Updated Feb. 4, 2013, 3:46 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a simple plugin-system to the NepomukCleaner allowing \
other applications to install Nepomuk2::CleaningJobs whcih are run in addition to the \
default jobs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implemented two CleaningJobs for TV shows - works fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cleaner/CMakeLists.txt <span style="color: grey">(af7f94b)</span></li>

 <li>cleaner/cleaningjob.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cleaner/cleaningjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cleaner/cleaningjobs.h <span style="color: grey">(e17bdfe)</span></li>

 <li>cleaner/cleaningjobs.cpp <span style="color: grey">(05addda)</span></li>

 <li>cleaner/jobmodel.h <span style="color: grey">(a7b0618)</span></li>

 <li>cleaner/jobmodel.cpp <span style="color: grey">(8aadc83)</span></li>

 <li>cleaner/nepomukcleaningjob.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108773/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 