[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: Port gwenview to using nepomuk-core
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2013-01-05 15:22:39
Message-ID: 20130105152239.472.70365 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 5, 2013, 2:35 p.m., Luis Silva wrote:
> > No problems that I cans see. Tested the patch and it seems to work.
> > It's a "Ship It!" from me just don't know which branch it should go to.
> =
> Jekyll Wu wrote:
> Now that we are already in RC2 for 4.10, I this this should only go i=
nto the master branch. Also the porting will introduce dependency change, =
another bad thing for release. =
> =
> @Aur=C3=A9lien, do you think this porting deserves asking for excepti=
on from release team ? (Hint: No :) )
> =
> =
>
Nepomuk2 is better than Nepomuk in almost every way. However, I don't think=
this is 'exception worthy'. The old "Nepomuk" API works fine, and there ar=
e no major bugs that require Gwenview to be ported in time for 4.10.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108190/#review24740
-----------------------------------------------------------
On Jan. 5, 2013, 11:27 a.m., Jekyll Wu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108190/
> -----------------------------------------------------------
> =
> (Updated Jan. 5, 2013, 11:27 a.m.)
> =
> =
> Review request for Gwenview, Nepomuk and Vishesh Handa.
> =
> =
> Description
> -------
> =
> The change is mostly done by the porting script in http://techbase.kde.or=
g/Projects/Nepomuk/Nepomuk2Port . I just make 2 minimum change manually to =
make it build and (seemingly) work.
> =
> * Remove "#include <nepomuk2/global.h>", since that header is no longer=
available in nepomuk-core
> * Change "find_package(Nepomuk)" to "find_package(NepomukCore)" and rel=
ated parts =
> =
> =
> PS: I'm not familiar with the code of neither gwenview nor nepomuk. I com=
e up with this porting patch because gwenview crashes/hangs for me due to k=
delibs/nepomuk from time to time ...
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt ce64825 =
> app/CMakeLists.txt 6627427 =
> app/filtercontroller.cpp c86ed9f =
> app/mainwindow.cpp 57f33a1 =
> app/startmainpage.cpp 1141c9e =
> lib/CMakeLists.txt d3f795f =
> lib/semanticinfo/nepomuksemanticinfobackend.cpp 606214c =
> tests/auto/CMakeLists.txt 6613f4e =
> tests/auto/semanticinfobackendtest.cpp 2f670e5 =
> =
> Diff: http://git.reviewboard.kde.org/r/108190/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Jekyll Wu
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108190/">http://git.reviewboard.kde.org/r/108190/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 5th, 2013, 2:35 p.m., <b>Luis Silva</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No problems \
that I cans see. Tested the patch and it seems to work. It's a "Ship \
It!" from me just don't know which branch it should go to.</pre> \
</blockquote>
<p>On January 5th, 2013, 3:07 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now that we are already \
in RC2 for 4.10, I this this should only go into the master branch. Also the porting \
will introduce dependency change, another bad thing for release.
@Aurélien, do you think this porting deserves asking for exception from release team \
? (Hint: No :) )
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nepomuk2 is better than \
Nepomuk in almost every way. However, I don't think this is 'exception \
worthy'. The old "Nepomuk" API works fine, and there are no major bugs \
that require Gwenview to be ported in time for 4.10.</pre> <br />
<p>- Vishesh</p>
<br />
<p>On January 5th, 2013, 11:27 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Gwenview, Nepomuk and Vishesh Handa.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2013, 11:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The change is mostly done by the porting script in \
http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port . I just make 2 minimum change \
manually to make it build and (seemingly) work.
* Remove "#include <nepomuk2/global.h>", since that header is no \
longer available in nepomuk-core
* Change "find_package(Nepomuk)" to "find_package(NepomukCore)" \
and related parts
PS: I'm not familiar with the code of neither gwenview nor nepomuk. I come up \
with this porting patch because gwenview crashes/hangs for me due to kdelibs/nepomuk \
from time to time ... </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ce64825)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(6627427)</span></li>
<li>app/filtercontroller.cpp <span style="color: grey">(c86ed9f)</span></li>
<li>app/mainwindow.cpp <span style="color: grey">(57f33a1)</span></li>
<li>app/startmainpage.cpp <span style="color: grey">(1141c9e)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(d3f795f)</span></li>
<li>lib/semanticinfo/nepomuksemanticinfobackend.cpp <span style="color: \
grey">(606214c)</span></li>
<li>tests/auto/CMakeLists.txt <span style="color: grey">(6613f4e)</span></li>
<li>tests/auto/semanticinfobackendtest.cpp <span style="color: \
grey">(2f670e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108190/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic