--===============2607740490195165417== Content-Type: multipart/alternative; boundary="===============5176819762105558198==" --===============5176819762105558198== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107806/#review23783 ----------------------------------------------------------- Ship it! I cannot really say. A lot of distros aren't going to ship the ffmpeg extra= ctor. But then we shouldn't care about them. Ideally, it would be awesome if there was some way to check if the ffmpeg e= xtractor is not installed and then use taglib. Oh well. Ship it for now. - Vishesh Handa On Dec. 18, 2012, 11:18 p.m., Hrvoje Senjan wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107806/ > ----------------------------------------------------------- > = > (Updated Dec. 18, 2012, 11:18 p.m.) > = > = > Review request for Nepomuk and Vishesh Handa. > = > = > Description > ------- > = > Super-trivial fix, swap video/mp4 filetype from TagLibExtractor to FFmpeg= Extractor, didn't see any specific reason why it should be indexed with Tag= LibExtractor and also it chokes with some of mp4 files. > = > = > Diffs > ----- > = > services/fileindexer/indexer/ffmpegextractor.cpp bf0d1d9 = > services/fileindexer/indexer/taglibextractor.cpp 3b2d3cb = > = > Diff: http://git.reviewboard.kde.org/r/107806/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Hrvoje Senjan > = > --===============5176819762105558198== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107806/ |
Ship it!
I cannot r= eally say. A lot of distros aren't going to ship the ffmpeg extractor. = But then we shouldn't care about them. Ideally, it would be awesome if there was some way to check if the ffmpeg e= xtractor is not installed and then use taglib. Oh well. Ship it for now.
- Vishesh
On December 18th, 2012, 11:18 p.m., Hrvoje Senjan wrote:
Review request for Nepomuk and Vishesh Handa.
By Hrvoje Senjan.
Updated Dec. 18, 2012, 11:18 p.m. Descripti= on
Diffs=
|