This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107806/

Ship it!

I cannot really say. A lot of distros aren't going to ship the ffmpeg extractor. But then we shouldn't care about them.

Ideally, it would be awesome if there was some way to check if the ffmpeg extractor is not installed and then use taglib. Oh well. Ship it for now.

- Vishesh

On December 18th, 2012, 11:18 p.m., Hrvoje Senjan wrote:

Review request for Nepomuk and Vishesh Handa.

By Hrvoje Senjan.

Updated Dec. 18, 2012, 11:18 p.m.

Description

Super-trivial fix, swap video/mp4 filetype from TagLibExtractor to FFmpegExtractor, didn't see any specific reason why it should be indexed with TagLibExtractor and also it chokes with some of mp4 files.

Diffs

services/fileindexer/indexer/ffmpegextractor.cpp (bf0d1d9)
services/fileindexer/indexer/taglibextractor.cpp (3b2d3cb)

View Diff