'Re: [Nepomuk] Review Request: FFmpegExtractor should index mp4 files, instead of TagLibExtractor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    Re: [Nepomuk] Review Request: FFmpegExtractor should index mp4 files, instead of  TagLibExtractor
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2012-12-18 23:18:46
Message-ID: 20121218231846.22455.76425 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107806/
-----------------------------------------------------------

(Updated Dec. 18, 2012, 11:18 p.m.)

Review request for Nepomuk and Vishesh Handa.

Changes
-------

Damn Kate :-( now's good

Description
-------

Super-trivial fix, swap video/mp4 filetype from TagLibExtractor to FFmpegEx=
tractor, didn't see any specific reason why it should be indexed with TagLi=
bExtractor and also it chokes with some of mp4 files.

Diffs (updated)
-----

  services/fileindexer/indexer/ffmpegextractor.cpp bf0d1d9 =

  services/fileindexer/indexer/taglibextractor.cpp 3b2d3cb =

Diff: http://git.reviewboard.kde.org/r/107806/diff/

Testing
-------

Thanks,

Hrvoje Senjan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107806/">http://git.reviewboard.kde.org/r/107806/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated Dec. 18, 2012, 11:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Damn Kate :-( now&#39;s good</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Super-trivial fix, swap video/mp4 filetype from TagLibExtractor to \
FFmpegExtractor, didn&#39;t see any specific reason why it should be indexed with \
TagLibExtractor and also it chokes with some of mp4 files.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>services/fileindexer/indexer/ffmpegextractor.cpp <span style="color: \
grey">(bf0d1d9)</span></li>

 <li>services/fileindexer/indexer/taglibextractor.cpp <span style="color: \
grey">(3b2d3cb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107806/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 