'[Nepomuk] Review Request: Make ${NEPOMUK_CORE_DBUS_INTERFACES_DIR} an absolute path; fixes problem b'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    [Nepomuk] Review Request: Make ${NEPOMUK_CORE_DBUS_INTERFACES_DIR} an absolute path; fixes problem b
From:       "Thomas Friedrichsmeier" <thomas.friedrichsmeier () ruhr-uni-bochum ! de>
Date:       2012-12-11 12:39:44
Message-ID: 20121211123944.8417.83780 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107665/
-----------------------------------------------------------

Review request for kdewin and Nepomuk.

Description
-------

Frankly, I am not sure at all, whether this is the correct place to fix the=
 issue.
Either way, without this, building of kde-runtime on WinXP fails, because c=
alls like the following (in kde-runtime/nepomuk/kcm/CMakeLists.txt):
  qt4_add_dbus_interface(kcmnepomuk_SRCS ${NEPOMUK_CORE_DBUS_INTERFACES_DIR=
}/org.kde.NepomukServer.xml nepomukserverinterface)
will look for the interface in a location _relative_ to the current sources=
. Sorry, I forgot to make a copy of the exact error message.

Making ${NEPOMUK_CORE_DBUS_INTERFACES_DIR} an absolute path works around th=
is, successfully, but again, I'm not sure, whether that is the correct fix.

Diffs
-----

  NepomukCoreConfig.cmake.in 81c084b50ea065d98798bf86e698dfdf1c8284d7 =

Diff: http://git.reviewboard.kde.org/r/107665/diff/

Testing
-------

With the patch to nepomuk-core, kde-runtime compiles with MinGW4 on WinXP. =
Previously it did not.

Thanks,

Thomas Friedrichsmeier

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107665/">http://git.reviewboard.kde.org/r/107665/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdewin and Nepomuk.</div>
<div>By Thomas Friedrichsmeier.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Frankly, I am not sure at all, whether this is the correct place to fix \
the issue. Either way, without this, building of kde-runtime on WinXP fails, because \
calls like the following (in kde-runtime/nepomuk/kcm/CMakeLists.txt):  \
qt4_add_dbus_interface(kcmnepomuk_SRCS \
${NEPOMUK_CORE_DBUS_INTERFACES_DIR}/org.kde.NepomukServer.xml nepomukserverinterface) \
will look for the interface in a location _relative_ to the current sources. Sorry, I \
forgot to make a copy of the exact error message.

Making ${NEPOMUK_CORE_DBUS_INTERFACES_DIR} an absolute path works around this, \
successfully, but again, I&#39;m not sure, whether that is the correct fix.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With the patch to nepomuk-core, kde-runtime compiles with MinGW4 on \
WinXP. Previously it did not.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>NepomukCoreConfig.cmake.in <span style="color: \
grey">(81c084b50ea065d98798bf86e698dfdf1c8284d7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107665/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 