[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: ResourceWatcher: Do no create a new ResourceManager on quit
From: "Commit Hook" <null () kde ! org>
Date: 2012-12-10 9:17:40
Message-ID: 20121210091740.5616.20861 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107573/#review23256
-----------------------------------------------------------
This review has been submitted with commit 5632983386e998d67954f7a7de470bab2184eaf3 \
by Vishesh Handa to branch master.
- Commit Hook
On Dec. 6, 2012, 8:40 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107573/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2012, 8:40 a.m.)
>
>
> Review request for Nepomuk, Sebastian Trueg and Simeon Bird.
>
>
> Description
> -------
>
> ResourceWatcher: Do no create a new ResourceManager on quit
>
> The ResourceManager contains a ResourceWatcher. This ResourceWatcher is
> initialized only when a Resource class requires it. On destruction it
> calls ResourceWatcher::stop, which tries to disconnect it from
> ResourceManager::nepomukSystemStarted signal.
>
> The problem arises when the application is exiting, and the
> ResourceManager (being a child of QCoreApplication) is being destroyed.
> It in turn destroys the ResourceWatcher, which calls
> ResourceWatcher::stop, which calls ResourceManager::instance() which
> results in the creation of a new ResourceManager whose parent is
> QCoreApplication::instance, which is 0, cause the application is
> shutting down.
>
> This whole extra ResourceManager being allocated is not required and can
> be avoided by checking if QCoreApplication != 0, in
> ResourceManager::instance.
>
> Also, since ResourceManager::instance() can now return 0. I've added an
> assert check in the Resource class.
>
>
> Diffs
> -----
>
> libnepomukcore/datamanagement/resourcewatcher.cpp a09b646
> libnepomukcore/resource/resource.cpp 4601eba
> libnepomukcore/resource/resourcemanager.cpp 457c042
>
> Diff: http://git.reviewboard.kde.org/r/107573/diff/
>
>
> Testing
> -------
>
> Added breakpoints in gdb, and wrote a simple application. The extra ResourceManager \
> is no longer being created.
>
> Thanks,
>
> Vishesh Handa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107573/">http://git.reviewboard.kde.org/r/107573/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5632983386e998d67954f7a7de470bab2184eaf3 by Vishesh Handa to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 6th, 2012, 8:40 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk, Sebastian Trueg and Simeon Bird.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2012, 8:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> ResourceWatcher: Do no create a new ResourceManager on quit
The ResourceManager contains a ResourceWatcher. This ResourceWatcher is
initialized only when a Resource class requires it. On destruction it
calls ResourceWatcher::stop, which tries to disconnect it from
ResourceManager::nepomukSystemStarted signal.
The problem arises when the application is exiting, and the
ResourceManager (being a child of QCoreApplication) is being destroyed.
It in turn destroys the ResourceWatcher, which calls
ResourceWatcher::stop, which calls ResourceManager::instance() which
results in the creation of a new ResourceManager whose parent is
QCoreApplication::instance, which is 0, cause the application is
shutting down.
This whole extra ResourceManager being allocated is not required and can
be avoided by checking if QCoreApplication != 0, in
ResourceManager::instance.
Also, since ResourceManager::instance() can now return 0. I've added an
assert check in the Resource class.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added breakpoints in gdb, and wrote a simple application. The extra \
ResourceManager is no longer being created.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libnepomukcore/datamanagement/resourcewatcher.cpp <span style="color: \
grey">(a09b646)</span></li>
<li>libnepomukcore/resource/resource.cpp <span style="color: \
grey">(4601eba)</span></li>
<li>libnepomukcore/resource/resourcemanager.cpp <span style="color: \
grey">(457c042)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107573/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic