[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: Fix recently introduced bug in the handling of EventUnmount in filewat
From: "Sebastian Trueg" <sebastian () trueg ! de>
Date: 2012-11-10 8:58:40
Message-ID: 20121110085840.7754.43419 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107259/#review21758
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Trueg
On Nov. 9, 2012, 12:46 a.m., Simeon Bird wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107259/
> -----------------------------------------------------------
> =
> (Updated Nov. 9, 2012, 12:46 a.m.)
> =
> =
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> When we get an EventUnmount with path '/', do not break the while loop.
> =
> Breaking means that we lose any further events in the buffer,
> and that unmounted folders are not correctly removed from
> the path hashes.
> =
> Instead, fix the crash by changing the assert to just not trigger if path=
is / and the event is EventUnmount.
> Then do not emit unmounted with a meaningless path.
> =
> This fixes a potential bug before it was released anywhere
> =
> =
> Diffs
> -----
> =
> services/filewatch/kinotify.cpp 54947fc =
> =
> Diff: http://git.reviewboard.kde.org/r/107259/diff/
> =
> =
> Testing
> -------
> =
> Compiled, ran for a while.
> =
> =
> Thanks,
> =
> Simeon Bird
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107259/">http://git.reviewboard.kde.org/r/107259/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Sebastian</p>
<br />
<p>On November 9th, 2012, 12:46 a.m., Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2012, 12:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When we get an EventUnmount with path '/', do not break the \
while loop.
Breaking means that we lose any further events in the buffer,
and that unmounted folders are not correctly removed from
the path hashes.
Instead, fix the crash by changing the assert to just not trigger if path is / and \
the event is EventUnmount. Then do not emit unmounted with a meaningless path.
This fixes a potential bug before it was released anywhere
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, ran for a while.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/filewatch/kinotify.cpp <span style="color: grey">(54947fc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107259/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic