'[Nepomuk] Review Request: Create a taskbar notification window when we run out of inotify watches'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    [Nepomuk] Review Request: Create a taskbar notification window when we run out of inotify watches
From:       "Simeon Bird" <bladud () gmail ! com>
Date:       2012-10-06 19:33:04
Message-ID: 20121006193304.6326.81299 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106748/
-----------------------------------------------------------

Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.

Description
-------

Currently, if we happen to run out of inotify watches in the filewatch service, all \
we get is a debug message, which is easily lost. This patch additionally creates a \
popup notification to warn people they need to raise the limit.

I worried that a popup might be a bit too invasive - I considered also just logging \
to syslog, but that seemed not invasive enough.  I figured that since metadata can \
get lost if the watches are not all installed, being fairly invasive is a good idea. 

What think you?

Diffs
-----

  services/filewatch/nepomukfilewatch.cpp 83045da 
  services/filewatch/nepomukfilewatch.notifyrc bfa88a9 

Diff: http://git.reviewboard.kde.org/r/106748/diff/

Testing
-------

> sudo sysctl fs.inotify.max_user_watches=10 
> killall nepomukserver && nepomukserver

Yup, there's a notification.

Thanks,

Simeon Bird

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106748/">http://git.reviewboard.kde.org/r/106748/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Simeon Bird.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, if we happen to run out of inotify watches in the filewatch \
service, all we get is a debug message, which is easily lost. This patch additionally \
creates a popup notification to warn people they need to raise the limit.

I worried that a popup might be a bit too invasive - I considered also just logging \
to syslog, but that seemed not invasive enough.  I figured that since metadata can \
get lost if the watches are not all installed, being fairly invasive is a good idea. 

What think you?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">&gt; sudo sysctl fs.inotify.max_user_watches=10  &gt; killall \
nepomukserver &amp;&amp; nepomukserver

Yup, there&#39;s a notification.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>services/filewatch/nepomukfilewatch.cpp <span style="color: \
grey">(83045da)</span></li>

 <li>services/filewatch/nepomukfilewatch.notifyrc <span style="color: \
grey">(bfa88a9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106748/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 