'Re: [Nepomuk] Review Request: Resource: Minor optimization while loading the data'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    Re: [Nepomuk] Review Request: Resource: Minor optimization while loading the data
From:       "Sebastian Trueg" <sebastian () trueg ! de>
Date:       2012-10-02 13:33:13
Message-ID: 20121002133313.26475.90565 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106684/#review19749
-----------------------------------------------------------

Ship it!

Ship It!

- Sebastian Trueg

On Oct. 2, 2012, 9:39 a.m., Vishesh Handa wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106684/
> -----------------------------------------------------------
> =

> (Updated Oct. 2, 2012, 9:39 a.m.)
> =

> =

> Review request for Nepomuk and Sebastian Trueg.
> =

> =

> Description
> -------
> =

>     Resource: Minor optimization while loading the data
>     =

>     Avoid the double comparsion when loading each property because of
>     updateKickOffLists( .. ). Instead, we directly update the relevant ki=
ck
>     off lists after the data has been loaded into the cache.
> =

> =

> Diffs
> -----
> =

>   libnepomukcore/resource/resourcedata.cpp 8c4ae34 =

> =

> Diff: http://git.reviewboard.kde.org/r/106684/diff/
> =

> =

> Testing
> -------
> =

> All the tests pass
> =

> =

> Thanks,
> =

> Vishesh Handa
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106684/">http://git.reviewboard.kde.org/r/106684/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Sebastian</p>

<br />
<p>On October 2nd, 2012, 9:39 a.m., Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated Oct. 2, 2012, 9:39 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Resource: Minor optimization while loading the data  
    Avoid the double comparsion when loading each property because of
    updateKickOffLists( .. ). Instead, we directly update the relevant kick
    off lists after the data has been loaded into the cache.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All the tests pass</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libnepomukcore/resource/resourcedata.cpp <span style="color: \
grey">(8c4ae34)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106684/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 