[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: Virtuoso Backend: Make empty graph support optional
From: "Sebastian Trueg" <sebastian () trueg ! de>
Date: 2012-10-02 8:28:25
Message-ID: 20121002082825.27363.99466 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106520/#review19728
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Trueg
On Oct. 2, 2012, 6:16 a.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106520/
> -----------------------------------------------------------
> =
> (Updated Oct. 2, 2012, 6:16 a.m.)
> =
> =
> Review request for Nepomuk, Soprano and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> Virtuoso doesn't support empty graphs, so we use a fake graph which a=
cts
> as the default empty graph.
> =
> This approach, while useful, does have a performance impact, as the
> graph needs to be regularly checked agains't this default graph.
> =
> Therefore, we add an option to disable this feature. By default, this
> feature is enabled in order to preserve compatibility.
> =
> =
> Diffs
> -----
> =
> backends/virtuoso/virtuosobackend.cpp ca5070f =
> backends/virtuoso/virtuosomodel.h b5fa1f8 =
> backends/virtuoso/virtuosomodel.cpp 2bc6fe2 =
> backends/virtuoso/virtuosomodel_p.h af58d12 =
> backends/virtuoso/virtuosoqueryresultiteratorbackend.cpp 914a320 =
> =
> Diff: http://git.reviewboard.kde.org/r/106520/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106520/">http://git.reviewboard.kde.org/r/106520/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Sebastian</p>
<br />
<p>On October 2nd, 2012, 6:16 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk, Soprano and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2012, 6:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Virtuoso doesn't support empty graphs, so we use a fake graph \
which acts as the default empty graph.
This approach, while useful, does have a performance impact, as the
graph needs to be regularly checked agains't this default graph.
Therefore, we add an option to disable this feature. By default, this
feature is enabled in order to preserve compatibility.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/virtuoso/virtuosobackend.cpp <span style="color: \
grey">(ca5070f)</span></li>
<li>backends/virtuoso/virtuosomodel.h <span style="color: \
grey">(b5fa1f8)</span></li>
<li>backends/virtuoso/virtuosomodel.cpp <span style="color: \
grey">(2bc6fe2)</span></li>
<li>backends/virtuoso/virtuosomodel_p.h <span style="color: \
grey">(af58d12)</span></li>
<li>backends/virtuoso/virtuosoqueryresultiteratorbackend.cpp <span style="color: \
grey">(914a320)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106520/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic