[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    Re: [Nepomuk] Review Request: LibNepomukCore: Update the header guards to Nepomuk2
From:       "Sebastian Trueg" <sebastian () trueg ! de>
Date:       2012-09-25 12:29:47
Message-ID: 20120925122947.31614.26957 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106564/#review19410
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Trueg


On Sept. 25, 2012, 11:02 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106564/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 11:02 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>    
>     This way once can compile both Nepomuk1 and Nepomuk2 in the same
>     application.
>     
>     BUG: 306081
> 
> 
> This addresses bug 306081.
>     http://bugs.kde.org/show_bug.cgi?id=306081
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/misc/nepomukversion.h.cmake bcbc322 
>   libnepomukcore/misc/utils.h 83a39c9 
>   libnepomukcore/nepomuk_export.h 35c8619 
>   libnepomukcore/query/andterm.h a595e04 
>   libnepomukcore/query/andterm_p.h b9f529f 
>   libnepomukcore/query/comparisonterm.h 9197919 
>   libnepomukcore/query/comparisonterm_p.h 8fb139a 
>   libnepomukcore/query/dbusoperators_p.h 4a322dd 
>   libnepomukcore/query/filequery.h 3e65eea 
>   libnepomukcore/query/groupterm.h 5861e06 
>   libnepomukcore/query/groupterm_p.h 4201665 
>   libnepomukcore/query/literalterm.h 9e3e8cf 
>   libnepomukcore/query/literalterm_p.h dc90804 
>   libnepomukcore/query/negationterm.h 1df24b8 
>   libnepomukcore/query/negationterm_p.h 35a9897 
>   libnepomukcore/query/optionalterm.h 091258b 
>   libnepomukcore/query/optionalterm_p.h cc6d6ed 
>   libnepomukcore/query/orterm.h 45ed810 
>   libnepomukcore/query/orterm_p.h 9d29b42 
>   libnepomukcore/query/query.h 2e043fb 
>   libnepomukcore/query/query_p.h adb92a7 
>   libnepomukcore/query/querybuilderdata_p.h 2cdb1d4 
>   libnepomukcore/query/queryparser.h 9ad052d 
>   libnepomukcore/query/queryserializer.h 26181f9 
>   libnepomukcore/query/queryserviceclient.h 948748d 
>   libnepomukcore/query/queryserviceclient_p.h c5e5567 
>   libnepomukcore/query/resourceterm.h e603dfd 
>   libnepomukcore/query/resourceterm_p.h 826476e 
>   libnepomukcore/query/resourcetypeterm.h 970aa4d 
>   libnepomukcore/query/resourcetypeterm_p.h 167be38 
>   libnepomukcore/query/result.h da825fa 
>   libnepomukcore/query/simpleterm.h f9a01be 
>   libnepomukcore/query/simpleterm_p.h 323eeac 
>   libnepomukcore/query/standardqueries.h ed1d6a4 
>   libnepomukcore/query/term.h 8a76df3 
>   libnepomukcore/query/term_p.h 3b0979d 
>   libnepomukcore/query/util.h 9002813 
>   libnepomukcore/resource/file.h e330be0 
>   libnepomukcore/resource/nepomukmainmodel.h 0ae2cc5 
>   libnepomukcore/resource/nepomukservice.h 97ea18d 
>   libnepomukcore/resource/resource.h 98238cd 
>   libnepomukcore/resource/resourcedata.h 7e185a7 
>   libnepomukcore/resource/resourcemanager.h e04ac65 
>   libnepomukcore/resource/resourcemanager_p.h 867bda3 
>   libnepomukcore/resource/tag.h dd0bb8e 
>   libnepomukcore/resource/tools.h ab5668d 
>   libnepomukcore/resource/variant.h 7f7e956 
>   libnepomukcore/test/qtest_querytostring.h f248f5f 
>   libnepomukcore/test/queryparsertest.h 920d856 
>   libnepomukcore/test/queryserializertest.h 04f482a 
>   libnepomukcore/test/querytest.h 881b2bb 
>   libnepomukcore/types/class.h e18c0c4 
>   libnepomukcore/types/class_p.h 0c41326 
>   libnepomukcore/types/entity.h 03baff0 
>   libnepomukcore/types/entity_p.h 05b7d44 
>   libnepomukcore/types/entitymanager.h 6f50b3d 
>   libnepomukcore/types/literal.h f764b44 
>   libnepomukcore/types/literal_p.h 46615ab 
>   libnepomukcore/types/ontology.h a1da759 
>   libnepomukcore/types/ontology_p.h a3abbdd 
>   libnepomukcore/types/property.h 65cb621 
>   libnepomukcore/types/property_p.h f794ee5 
> 
> Diff: http://git.reviewboard.kde.org/r/106564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106564/">http://git.reviewboard.kde.org/r/106564/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />







<p>- Sebastian</p>


<br />
<p>On September 25th, 2012, 11:02 a.m., Vishesh Handa wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>


<p style="color: grey;"><i>Updated Sept. 25, 2012, 11:02 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">     This way once can compile both Nepomuk1 and Nepomuk2 in the same
    application.
    
    BUG: 306081
</pre>
  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=306081">306081</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libnepomukcore/misc/nepomukversion.h.cmake <span style="color: \
grey">(bcbc322)</span></li>

 <li>libnepomukcore/misc/utils.h <span style="color: grey">(83a39c9)</span></li>

 <li>libnepomukcore/nepomuk_export.h <span style="color: grey">(35c8619)</span></li>

 <li>libnepomukcore/query/andterm.h <span style="color: grey">(a595e04)</span></li>

 <li>libnepomukcore/query/andterm_p.h <span style="color: grey">(b9f529f)</span></li>

 <li>libnepomukcore/query/comparisonterm.h <span style="color: \
grey">(9197919)</span></li>

 <li>libnepomukcore/query/comparisonterm_p.h <span style="color: \
grey">(8fb139a)</span></li>

 <li>libnepomukcore/query/dbusoperators_p.h <span style="color: \
grey">(4a322dd)</span></li>

 <li>libnepomukcore/query/filequery.h <span style="color: grey">(3e65eea)</span></li>

 <li>libnepomukcore/query/groupterm.h <span style="color: grey">(5861e06)</span></li>

 <li>libnepomukcore/query/groupterm_p.h <span style="color: \
grey">(4201665)</span></li>

 <li>libnepomukcore/query/literalterm.h <span style="color: \
grey">(9e3e8cf)</span></li>

 <li>libnepomukcore/query/literalterm_p.h <span style="color: \
grey">(dc90804)</span></li>

 <li>libnepomukcore/query/negationterm.h <span style="color: \
grey">(1df24b8)</span></li>

 <li>libnepomukcore/query/negationterm_p.h <span style="color: \
grey">(35a9897)</span></li>

 <li>libnepomukcore/query/optionalterm.h <span style="color: \
grey">(091258b)</span></li>

 <li>libnepomukcore/query/optionalterm_p.h <span style="color: \
grey">(cc6d6ed)</span></li>

 <li>libnepomukcore/query/orterm.h <span style="color: grey">(45ed810)</span></li>

 <li>libnepomukcore/query/orterm_p.h <span style="color: grey">(9d29b42)</span></li>

 <li>libnepomukcore/query/query.h <span style="color: grey">(2e043fb)</span></li>

 <li>libnepomukcore/query/query_p.h <span style="color: grey">(adb92a7)</span></li>

 <li>libnepomukcore/query/querybuilderdata_p.h <span style="color: \
grey">(2cdb1d4)</span></li>

 <li>libnepomukcore/query/queryparser.h <span style="color: \
grey">(9ad052d)</span></li>

 <li>libnepomukcore/query/queryserializer.h <span style="color: \
grey">(26181f9)</span></li>

 <li>libnepomukcore/query/queryserviceclient.h <span style="color: \
grey">(948748d)</span></li>

 <li>libnepomukcore/query/queryserviceclient_p.h <span style="color: \
grey">(c5e5567)</span></li>

 <li>libnepomukcore/query/resourceterm.h <span style="color: \
grey">(e603dfd)</span></li>

 <li>libnepomukcore/query/resourceterm_p.h <span style="color: \
grey">(826476e)</span></li>

 <li>libnepomukcore/query/resourcetypeterm.h <span style="color: \
grey">(970aa4d)</span></li>

 <li>libnepomukcore/query/resourcetypeterm_p.h <span style="color: \
grey">(167be38)</span></li>

 <li>libnepomukcore/query/result.h <span style="color: grey">(da825fa)</span></li>

 <li>libnepomukcore/query/simpleterm.h <span style="color: \
grey">(f9a01be)</span></li>

 <li>libnepomukcore/query/simpleterm_p.h <span style="color: \
grey">(323eeac)</span></li>

 <li>libnepomukcore/query/standardqueries.h <span style="color: \
grey">(ed1d6a4)</span></li>

 <li>libnepomukcore/query/term.h <span style="color: grey">(8a76df3)</span></li>

 <li>libnepomukcore/query/term_p.h <span style="color: grey">(3b0979d)</span></li>

 <li>libnepomukcore/query/util.h <span style="color: grey">(9002813)</span></li>

 <li>libnepomukcore/resource/file.h <span style="color: grey">(e330be0)</span></li>

 <li>libnepomukcore/resource/nepomukmainmodel.h <span style="color: \
grey">(0ae2cc5)</span></li>

 <li>libnepomukcore/resource/nepomukservice.h <span style="color: \
grey">(97ea18d)</span></li>

 <li>libnepomukcore/resource/resource.h <span style="color: \
grey">(98238cd)</span></li>

 <li>libnepomukcore/resource/resourcedata.h <span style="color: \
grey">(7e185a7)</span></li>

 <li>libnepomukcore/resource/resourcemanager.h <span style="color: \
grey">(e04ac65)</span></li>

 <li>libnepomukcore/resource/resourcemanager_p.h <span style="color: \
grey">(867bda3)</span></li>

 <li>libnepomukcore/resource/tag.h <span style="color: grey">(dd0bb8e)</span></li>

 <li>libnepomukcore/resource/tools.h <span style="color: grey">(ab5668d)</span></li>

 <li>libnepomukcore/resource/variant.h <span style="color: \
grey">(7f7e956)</span></li>

 <li>libnepomukcore/test/qtest_querytostring.h <span style="color: \
grey">(f248f5f)</span></li>

 <li>libnepomukcore/test/queryparsertest.h <span style="color: \
grey">(920d856)</span></li>

 <li>libnepomukcore/test/queryserializertest.h <span style="color: \
grey">(04f482a)</span></li>

 <li>libnepomukcore/test/querytest.h <span style="color: grey">(881b2bb)</span></li>

 <li>libnepomukcore/types/class.h <span style="color: grey">(e18c0c4)</span></li>

 <li>libnepomukcore/types/class_p.h <span style="color: grey">(0c41326)</span></li>

 <li>libnepomukcore/types/entity.h <span style="color: grey">(03baff0)</span></li>

 <li>libnepomukcore/types/entity_p.h <span style="color: grey">(05b7d44)</span></li>

 <li>libnepomukcore/types/entitymanager.h <span style="color: \
grey">(6f50b3d)</span></li>

 <li>libnepomukcore/types/literal.h <span style="color: grey">(f764b44)</span></li>

 <li>libnepomukcore/types/literal_p.h <span style="color: grey">(46615ab)</span></li>

 <li>libnepomukcore/types/ontology.h <span style="color: grey">(a1da759)</span></li>

 <li>libnepomukcore/types/ontology_p.h <span style="color: \
grey">(a3abbdd)</span></li>

 <li>libnepomukcore/types/property.h <span style="color: grey">(65cb621)</span></li>

 <li>libnepomukcore/types/property_p.h <span style="color: \
grey">(f794ee5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106564/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic