'Re: [Nepomuk] Review Request: ResourceMerger: Optimize resolveUnMappedNode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    Re: [Nepomuk] Review Request: ResourceMerger: Optimize resolveUnMappedNode
From:       "Sebastian Trueg" <sebastian () trueg ! de>
Date:       2012-09-19 17:21:13
Message-ID: 20120919172113.2583.79398 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106492/#review19179
-----------------------------------------------------------

Ship it!

Ship It!

- Sebastian Trueg

On Sept. 19, 2012, 12:08 p.m., Vishesh Handa wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106492/
> -----------------------------------------------------------
> =

> (Updated Sept. 19, 2012, 12:08 p.m.)
> =

> =

> Review request for Nepomuk and Sebastian Trueg.
> =

> =

> Description
> -------
> =

>     Only convert the node to n3 once. And insert the statements in one go,
>     thereby avoiding the extra conversion via Soprano::Node::resourceToN3=
( .. )
> =

> Yes, I know, it's micro optimization. But this piece of code is called a =
lot.
> =

> =

> Diffs
> -----
> =

>   services/storage/test/qtest_dms.cpp ce91843 =

>   services/storage/test/resourcewatchertest.cpp 6a3941b =

>   services/storage/test/fakedatamanagementservice.cpp 991a4e7 =

>   services/storage/test/qtest_dms.h 5d21e4f =

>   services/storage/test/datamanagementadaptortest.cpp 8ffae7d =

>   services/storage/test/datamanagementmodeltest.cpp fc97f4b =

>   services/storage/resourcemerger.cpp 1bc87ee =

> =

> Diff: http://git.reviewboard.kde.org/r/106492/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Vishesh Handa
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106492/">http://git.reviewboard.kde.org/r/106492/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Sebastian</p>

<br />
<p>On September 19th, 2012, 12:08 p.m., Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated Sept. 19, 2012, 12:08 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Only convert the node to n3 once. And insert the statements in one \
go,  thereby avoiding the extra conversion via Soprano::Node::resourceToN3( .. )

Yes, I know, it&#39;s micro optimization. But this piece of code is called a \
lot.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>services/storage/test/qtest_dms.cpp <span style="color: \
grey">(ce91843)</span></li>

 <li>services/storage/test/resourcewatchertest.cpp <span style="color: \
grey">(6a3941b)</span></li>

 <li>services/storage/test/fakedatamanagementservice.cpp <span style="color: \
grey">(991a4e7)</span></li>

 <li>services/storage/test/qtest_dms.h <span style="color: \
grey">(5d21e4f)</span></li>

 <li>services/storage/test/datamanagementadaptortest.cpp <span style="color: \
grey">(8ffae7d)</span></li>

 <li>services/storage/test/datamanagementmodeltest.cpp <span style="color: \
grey">(fc97f4b)</span></li>

 <li>services/storage/resourcemerger.cpp <span style="color: \
grey">(1bc87ee)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106492/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 