[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: DataManagement: Optimize findApplicationResource by using a cache
From: "Sebastian Trueg" <sebastian () trueg ! de>
Date: 2012-09-18 8:04:07
Message-ID: 20120918080407.23958.50885 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106485/#review19095
-----------------------------------------------------------
Ship it!
Yet another good idea.
services/storage/datamanagementmodel.cpp
<http://git.reviewboard.kde.org/r/106485/#comment15182>
Why only 10 apps?
- Sebastian Trueg
On Sept. 17, 2012, 7:07 p.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106485/
> -----------------------------------------------------------
> =
> (Updated Sept. 17, 2012, 7:07 p.m.)
> =
> =
> Review request for Nepomuk and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> Instead of querying each time, we can use a QCache and cache the
> last 10 application resources.
> =
> =
> Diffs
> -----
> =
> services/storage/datamanagementmodel.h cf708da =
> services/storage/datamanagementmodel.cpp 4221a3c =
> services/storage/test/datamanagementadaptortest.cpp 839255b =
> services/storage/test/datamanagementmodeltest.cpp 62e2557 =
> services/storage/test/fakedatamanagementservice.cpp a864117 =
> services/storage/test/resourcewatchertest.cpp 860dcf1 =
> =
> Diff: http://git.reviewboard.kde.org/r/106485/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106485/">http://git.reviewboard.kde.org/r/106485/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yet another good \
idea.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106485/diff/2/?file=85801#file85801line198" \
style="color: black; font-weight: bold; text-decoration: \
underline;">services/storage/datamanagementmodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">198</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span class="n">m_appCache</span><span \
class="p">.</span><span class="n">setMaxCost</span><span class="p">(</span> <span \
class="mi">10</span> <span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why only 10 \
apps?</pre> </div>
<br />
<p>- Sebastian</p>
<br />
<p>On September 17th, 2012, 7:07 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2012, 7:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Instead of querying each time, we can use a QCache and cache the \
last 10 application resources. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/storage/datamanagementmodel.h <span style="color: \
grey">(cf708da)</span></li>
<li>services/storage/datamanagementmodel.cpp <span style="color: \
grey">(4221a3c)</span></li>
<li>services/storage/test/datamanagementadaptortest.cpp <span style="color: \
grey">(839255b)</span></li>
<li>services/storage/test/datamanagementmodeltest.cpp <span style="color: \
grey">(62e2557)</span></li>
<li>services/storage/test/fakedatamanagementservice.cpp <span style="color: \
grey">(a864117)</span></li>
<li>services/storage/test/resourcewatchertest.cpp <span style="color: \
grey">(860dcf1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106485/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic